Sign upLogin

egordorichev/LastTry

View on GitHub
Star
core/src/org/egordorichev/lasttry/inventory/InventorySlot.java

Summary

Maintainability
A
3 hrs
Test Coverage

Method canHold has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    default boolean canHold(ItemHolder holder) {
        switch (getType()) {
        case ANY:
        case TRASH:
        default:
Severity: Minor
Found in core/src/org/egordorichev/lasttry/inventory/InventorySlot.java - About 1 hr to fix

    Method canHold has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        default boolean canHold(ItemHolder holder) {
        switch (getType()) {
        case ANY:
        case TRASH:
        default:
    Severity: Minor
    Found in core/src/org/egordorichev/lasttry/inventory/InventorySlot.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return true;
    Severity: Major
    Found in core/src/org/egordorichev/lasttry/inventory/InventorySlot.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return false;
      Severity: Major
      Found in core/src/org/egordorichev/lasttry/inventory/InventorySlot.java - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status