Sign upLogin

egordorichev/LastTry

View on GitHub
Star
core/src/org/egordorichev/lasttry/ui/UiItemSlot.java

Summary

Maintainability
C
7 hrs
Test Coverage

Method onStateChange has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    protected void onStateChange() {
        UiInventory inventory = Globals.getPlayer().getInventory();
        if (this.state == State.MOUSE_DOWN && inventory.isOpen()) {
            if (InputManager.isMouseButtonPressed(Input.Buttons.LEFT)) {
Severity: Minor
Found in core/src/org/egordorichev/lasttry/ui/UiItemSlot.java - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method onStateChange has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    protected void onStateChange() {
        UiInventory inventory = Globals.getPlayer().getInventory();
        if (this.state == State.MOUSE_DOWN && inventory.isOpen()) {
            if (InputManager.isMouseButtonPressed(Input.Buttons.LEFT)) {
Severity: Minor
Found in core/src/org/egordorichev/lasttry/ui/UiItemSlot.java - About 1 hr to fix

    Method render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Override
    public void render() {
        if (this.hidden) {
            return;
        }
    Severity: Minor
    Found in core/src/org/egordorichev/lasttry/ui/UiItemSlot.java - About 1 hr to fix

      Method render has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    public void render() {
        if (this.hidden) {
            return;
        }
      Severity: Minor
      Found in core/src/org/egordorichev/lasttry/ui/UiItemSlot.java - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status