Sign upLogin

egordorichev/LastTry

View on GitHub
Star
core/src/org/egordorichev/lasttry/ui/chat/UiChat.java

Summary

Maintainability
D
1 day
Test Coverage

Method initCommands has 149 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void initCommands() {
        this.commands.register(new Command("help", "Shows a list of existing chat commands", CMDCategory.GAME) {
            @Override
            public void onRun(String[] args) {
                // TODO: Hide commands based on user permissions.
Severity: Major
Found in core/src/org/egordorichev/lasttry/ui/chat/UiChat.java - About 5 hrs to fix

    UiChat has 26 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class UiChat extends UiPanel implements UiScreen, UiToggleScreen {
    public static final int WIDTH = 400;
    public static final int HEIGHT = 300;
    /**
     * Chat is open
    Severity: Minor
    Found in core/src/org/egordorichev/lasttry/ui/chat/UiChat.java - About 3 hrs to fix

      File UiChat.java has 260 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      package org.egordorichev.lasttry.ui.chat;

import com.badlogic.gdx.Gdx;
import com.badlogic.gdx.Input;
import com.badlogic.gdx.graphics.g2d.TextureRegion;
      Severity: Minor
      Found in core/src/org/egordorichev/lasttry/ui/chat/UiChat.java - About 2 hrs to fix

        Method render has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            @Override
    public void render() {
        if (this.open) {
            Graphics.batch.draw(this.back, 5, 5);
            super.render();
        Severity: Minor
        Found in core/src/org/egordorichev/lasttry/ui/chat/UiChat.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                this.commands.register(new Command("startset", "Gives you a start set", CMDCategory.DEBUG) {
            @Override
            public void onRun(String[] args) {
                Globals.getPlayer().getInventory().clear();
                Globals.getPlayer().getInventory().add(new ItemHolder(itemManager.getItem("lt:copper_shortsword"), 1));
        Severity: Major
        Found in core/src/org/egordorichev/lasttry/ui/chat/UiChat.java and 1 other location - About 1 hr to fix
        core/src/org/egordorichev/lasttry/ui/chat/UiChat.java on lines 188..196

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                this.commands.register(new Command("devset", "Gives you a dev set", CMDCategory.DEBUG) {
            @Override
            public void onRun(String[] args) {
                Globals.getPlayer().getInventory().clear();
                Globals.getPlayer().getInventory().add(new ItemHolder(itemManager.getItem("lt:superpick"), 1));
        Severity: Major
        Found in core/src/org/egordorichev/lasttry/ui/chat/UiChat.java and 1 other location - About 1 hr to fix
        core/src/org/egordorichev/lasttry/ui/chat/UiChat.java on lines 198..206

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                this.commands.register(new Command("day", "Sets the time to day", CMDCategory.ADMININSTRATION) {
            @Override
            public void onRun(String[] args) {
                Globals.environment.time.setHour((byte) 4);
                Globals.environment.time.setMinute((byte) 30);
        Severity: Minor
        Found in core/src/org/egordorichev/lasttry/ui/chat/UiChat.java and 1 other location - About 40 mins to fix
        core/src/org/egordorichev/lasttry/ui/chat/UiChat.java on lines 159..165

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                this.commands.register(new Command("night", "Sets the time to night", CMDCategory.ADMININSTRATION) {
            @Override
            public void onRun(String[] args) {
                Globals.environment.time.setHour((byte) 20);
                Globals.environment.time.setMinute((byte) 30);
        Severity: Minor
        Found in core/src/org/egordorichev/lasttry/ui/chat/UiChat.java and 1 other location - About 40 mins to fix
        core/src/org/egordorichev/lasttry/ui/chat/UiChat.java on lines 151..157

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status