Sign upLogin

egordorichev/LastTry

View on GitHub
Star
core/src/org/egordorichev/lasttry/util/SimplexNoise.java

Summary

Maintainability
B
5 hrs
Test Coverage

Method noise has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static double noise(double xin, double yin) {
        double n0, n1, n2; // Noise contributions from the three corners
        // Skew the input space to determine which simplex cell we're in
        final double F2 = 0.5 * (Math.sqrt(3.0) - 1.0);
        double s = (xin + yin) * F2; // Hairy factor for 2D
Severity: Minor
Found in core/src/org/egordorichev/lasttry/util/SimplexNoise.java - About 1 hr to fix

    Method noise has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public static double noise(double xin, double yin) {
        double n0, n1, n2; // Noise contributions from the three corners
        // Skew the input space to determine which simplex cell we're in
        final double F2 = 0.5 * (Math.sqrt(3.0) - 1.0);
        double s = (xin + yin) * F2; // Hairy factor for 2D
    Severity: Minor
    Found in core/src/org/egordorichev/lasttry/util/SimplexNoise.java - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method octavedNoise has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public static float octavedNoise(float x, float y, int octaves, float roughness, float scale) {
    Severity: Minor
    Found in core/src/org/egordorichev/lasttry/util/SimplexNoise.java - About 35 mins to fix

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

              if (t2 < 0) n2 = 0.0;
        else {
            t2 *= t2;
            n2 = t2 * t2 * dot(grad3[gi2], x2, y2);
        }
      Severity: Major
      Found in core/src/org/egordorichev/lasttry/util/SimplexNoise.java and 2 other locations - About 40 mins to fix
      core/src/org/egordorichev/lasttry/util/SimplexNoise.java on lines 122..127
      core/src/org/egordorichev/lasttry/util/SimplexNoise.java on lines 129..133

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

              if (t1 < 0) n1 = 0.0;
        else {
            t1 *= t1;
            n1 = t1 * t1 * dot(grad3[gi1], x1, y1);
        }
      Severity: Major
      Found in core/src/org/egordorichev/lasttry/util/SimplexNoise.java and 2 other locations - About 40 mins to fix
      core/src/org/egordorichev/lasttry/util/SimplexNoise.java on lines 122..127
      core/src/org/egordorichev/lasttry/util/SimplexNoise.java on lines 135..139

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

              if (t0 < 0) n0 = 0.0;
        else {
            t0 *= t0;
            n0 = t0 * t0 * dot(grad3[gi0], x0, y0); // (x,y) of grad3 used for
                                                    // 2D gradient
      Severity: Major
      Found in core/src/org/egordorichev/lasttry/util/SimplexNoise.java and 2 other locations - About 40 mins to fix
      core/src/org/egordorichev/lasttry/util/SimplexNoise.java on lines 129..133
      core/src/org/egordorichev/lasttry/util/SimplexNoise.java on lines 135..139

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status