Sign upLogin

ehmorris/cardslap

View on GitHub
Star

Showing 7 of 7 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      $.ajax({
        type: 'POST',
        url: '/decks/'+deck_id+'/cards/'+id,
        data: {_method: 'PUT', card: {bin: 'main'}}
      });
Severity: Major
Found in app/assets/javascripts/dragdrop.js and 2 other locations - About 1 hr to fix
app/assets/javascripts/dragdrop.js on lines 141..145
app/assets/javascripts/quiz.js on lines 17..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      $.ajax({
        type: 'POST',
        url: "/decks/"+deck_id+"/cards/"+card_id,
        data: {_method: 'PUT', card: {bin: 'bin'}}
      });
Severity: Major
Found in app/assets/javascripts/quiz.js and 2 other locations - About 1 hr to fix
app/assets/javascripts/dragdrop.js on lines 94..98
app/assets/javascripts/dragdrop.js on lines 141..145

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      $.ajax({
        type: 'POST',
        url: "/decks/"+deck_id+"/cards/"+id,
        data: {_method: 'PUT', card: {bin: 'bin'}}
      });
Severity: Major
Found in app/assets/javascripts/dragdrop.js and 2 other locations - About 1 hr to fix
app/assets/javascripts/dragdrop.js on lines 94..98
app/assets/javascripts/quiz.js on lines 17..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function get_draggable has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function get_draggable() {
  var dragItems = $('[draggable=true]');

  dragItems.each(function() {
    addEvent($(this), 'dragstart', function (event) {
Severity: Minor
Found in app/assets/javascripts/dragdrop.js - About 1 hr to fix

    Method show has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def show
    if signed_in?
      @share = Share.find_by_id(params[:id])
      if @share.email == current_user.email
        @deck = Deck.find_by_id(params[:deck_id])
    Severity: Minor
    Found in app/controllers/shares_controller.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method header_deck_link has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def header_deck_link
    if (defined? @share and @share.persisted?) and defined? @deck
      link_to @deck.name, deck_share_path(@deck.id, @share)
    elsif ((defined? @card and @card.persisted?) or defined? @quiz) and defined? @deck
      link_to @deck.name, deck_path(@deck)
    Severity: Minor
    Found in app/helpers/application_helper.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def create
    @deck = current_user.decks.find(params[:deck_id])
    @share = @deck.shares.build(params[:share])
    email_errors = ValidatesEmailFormatOf::validate_email_format @share.email
    Severity: Minor
    Found in app/controllers/shares_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language