Sign upLogin

eidng8/sttbot

View on GitHub
Star
src/Wiki/Api/Api.php

Summary

Maintainability
A
0 mins
Test Coverage

The method query has a boolean flag argument $new, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function query(bool $new = false): Query
Severity: Minor
Found in src/Wiki/Api/Api.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method parse has a boolean flag argument $new, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function parse(bool $new = false): Parse
Severity: Minor
Found in src/Wiki/Api/Api.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method expandTemplates has a boolean flag argument $new, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function expandTemplates(bool $new = false): ExpandTemplates
Severity: Minor
Found in src/Wiki/Api/Api.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

There are no issues that match your filters.

Category
Status