src/Wiki/Api/ExpandTemplates.php
The method get has a boolean flag argument $fetch, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function get(string $text, bool $fetch = false): ?string
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}