tests/Wiki/ExporterTest.php
Method testExportedCharacters
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function testExportedCharacters(array $exported)
{
$this->assertSame(
count(static::$wiki->crew()->get()),
count($exported['crew'])
- Create a ticketCreate a ticket
Method testExportedMissions
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function testExportedMissions(array $exported)
{
$this->removeMissionTraitRich();
$idx = 0;
- Create a ticketCreate a ticket
Avoid using static access to class '\eidng8\Wiki\Models\Skills' in method 'checkMissionStepSkills'. Open
Open
Skills::skillName($expected['skills'][$idx]['names'][0]),
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}