Sign upLogin

eidng8/sttbot

View on GitHub
Star
tests/Wiki/ExporterTest.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method testExportedCharacters has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testExportedCharacters(array $exported)
    {
        $this->assertSame(
            count(static::$wiki->crew()->get()),
            count($exported['crew'])
Severity: Minor
Found in tests/Wiki/ExporterTest.php - About 1 hr to fix

Method testExportedMissions has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testExportedMissions(array $exported)
    {
        $this->removeMissionTraitRich();

        $idx = 0;
Severity: Minor
Found in tests/Wiki/ExporterTest.php - About 1 hr to fix

Avoid using static access to class '\eidng8\Wiki\Models\Skills' in method 'checkMissionStepSkills'.
Open

                Skills::skillName($expected['skills'][$idx]['names'][0]),
Severity: Minor
Found in tests/Wiki/ExporterTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

There are no issues that match your filters.

Category
Status