File MissionTest.php has 309 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* Created by PhpStorm.
* User: JC
* Date: 2016-11-28- Create a ticketCreate a ticket
Method checkCadetAdvMissionSteps has 65 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function checkCadetAdvMissionSteps(MissionModel $model)
{
$this->checkMissionStep(
$model->steps[0],
[- Create a ticketCreate a ticket
Method checkCadetMissionSteps has 65 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function checkCadetMissionSteps(MissionModel $model)
{
$this->checkMissionStep(
$model->steps[0],
[- Create a ticketCreate a ticket
Avoid using static access to class '\eidng8\Wiki\Templates\Mission' in method 'testCadetAdvLoad'. Open
$actual = Mission::load($text, null, ['advanced' => true]);- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\eidng8\Wiki\Templates\Mission' in method 'testToArray'. Open
$actual = Mission::load($text);- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\eidng8\Wiki\Templates\Mission' in method 'testLoad'. Open
$actual = Mission::load($text);- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\eidng8\Log\Log' in method 'setUp'. Open
Log::forTest();- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\eidng8\Wiki\Templates\Mission' in method 'testCadetLoad'. Open
$actual = Mission::load($text);- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}