Sign upLogin

eight0153/CartPole-NEAT

View on GitHub
Star
neat/main.py

Summary

Maintainability
B
4 hrs
Test Coverage
B
80%

Use of insecure MD2, MD4, MD5, or SHA1 hash function.
Open

        run_id_hash = hashlib.sha1()
Severity: Minor
Found in neat/main.py by bandit

Function train has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Confirmed

    def train(self, n_episodes=100, n_steps=200, n_pso_episodes=5,
              debug_mode=False):
        """Train species of individuals.

        Arguments:
Severity: Minor
Found in neat/main.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity is too high in method train. (14)
Open

    def train(self, n_episodes=100, n_steps=200, n_pso_episodes=5,
              debug_mode=False):
        """Train species of individuals.

        Arguments:
Severity: Minor
Found in neat/main.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

File main.py has 255 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

"""Implements the NEAT algorithm."""
import hashlib
import json
import os
from time import time
Severity: Minor
Found in neat/main.py - About 2 hrs to fix

    Function makes_the_grade has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def makes_the_grade(self, creature, n_steps):
        """Check if the creature 'passes' the environment.

        Returns: True if the creature passes, False otherwise.
        """
    Severity: Minor
    Found in neat/main.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function record_video has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def record_video(self, creature, n_episodes=20, n_steps=200):
        """Record a video of the creature trying to solve the problem.

        Arguments:
            creature: the creature to record.
    Severity: Minor
    Found in neat/main.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Refactor this function to reduce its Cognitive Complexity from 25 to the 15 allowed.
    Open

        def train(self, n_episodes=100, n_steps=200, n_pso_episodes=5,
    Severity: Critical
    Found in neat/main.py by sonar-python

    Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

    See

    Unexpected spaces around keyword / parameter equals
    Open

                    weight_unsameness_importance=
    Severity: Minor
    Found in neat/main.py by pep8

    Don't use spaces around the '=' sign in function arguments.

    Don't use spaces around the '=' sign when used to indicate a
keyword argument or a default parameter value, except when
using a type annotation.

Okay: def complex(real, imag=0.0):
Okay: return magic(r=real, i=imag)
Okay: boolean(a == b)
Okay: boolean(a != b)
Okay: boolean(a <= b)
Okay: boolean(a >= b)
Okay: def foo(arg: int = 42):
Okay: async def foo(arg: int = 42):

E251: def complex(real, imag = 0.0):
E251: return magic(r = real, i = imag)
E252: def complex(real, image: float=0.0):

    Line too long (84 > 79 characters)
    Open

                        np.mean(self.fitness_history[episode - self.n_trials:episode]) \
    Severity: Minor
    Found in neat/main.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Line too long (80 > 79 characters)
    Open

            Creature.disjointedness_importance = config['disjointedness_importance']
    Severity: Minor
    Found in neat/main.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    There are no issues that match your filters.

    Category
    Status