Sign upLogin

eight0153/CartPole-NEAT

View on GitHub
Star
neat/species.py

Summary

Maintainability
A
35 mins
Test Coverage
B
85%

Standard pseudo-random generators are not suitable for security/cryptographic purposes.
Open

            parent1 = random.choice(pool)
Severity: Info
Found in neat/species.py by bandit

Standard pseudo-random generators are not suitable for security/cryptographic purposes.
Open

            if random.random() < Species.p_interspecies_mating:
Severity: Info
Found in neat/species.py by bandit

Standard pseudo-random generators are not suitable for security/cryptographic purposes.
Open

                parent2 = random.choice(pool)
Severity: Info
Found in neat/species.py by bandit

Standard pseudo-random generators are not suitable for security/cryptographic purposes.
Open

            self.representative = random.choice(self.members)
Severity: Info
Found in neat/species.py by bandit

Standard pseudo-random generators are not suitable for security/cryptographic purposes.
Open

                parent2 = random.choice(population)
Severity: Info
Found in neat/species.py by bandit

Cyclomatic complexity is too high in method next_generation. (6)
Open

    def next_generation(self, generation_champ, population):
        """Get the species' next generation of creatures.

        Arguments:
            generation_champ: the best creature for the whole generation, who's
Severity: Minor
Found in neat/species.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function next_generation has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def next_generation(self, generation_champ, population):
        """Get the species' next generation of creatures.

        Arguments:
            generation_champ: the best creature for the whole generation, who's
Severity: Minor
Found in neat/species.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Continuation line over-indented for visual indent
Open

                copy.members[self.members.index(self.representative)]
Severity: Minor
Found in neat/species.py by pep8

Continuation lines indentation.

Continuation lines should align wrapped elements either vertically
using Python's implicit line joining inside parentheses, brackets
and braces, or using a hanging indent.

When using a hanging indent these considerations should be applied:
- there should be no arguments on the first line, and
- further indentation should be used to clearly distinguish itself
  as a continuation line.

Okay: a = (\n)
E123: a = (\n    )

Okay: a = (\n    42)
E121: a = (\n   42)
E122: a = (\n42)
E123: a = (\n    42\n    )
E124: a = (24,\n     42\n)
E125: if (\n    b):\n    pass
E126: a = (\n        42)
E127: a = (24,\n      42)
E128: a = (24,\n    42)
E129: if (a or\n    b):\n    pass
E131: a = (\n    42\n 24)

Blank line at end of file
Open

Severity: Minor
Found in neat/species.py by pep8

Trailing blank lines are superfluous.

Okay: spam(1)
W391: spam(1)\n

However the last line should end with a new line (warning W292).

Continuation line over-indented for visual indent
Open

               len(self.members)
Severity: Minor
Found in neat/species.py by pep8

Continuation lines indentation.

Continuation lines should align wrapped elements either vertically
using Python's implicit line joining inside parentheses, brackets
and braces, or using a hanging indent.

When using a hanging indent these considerations should be applied:
- there should be no arguments on the first line, and
- further indentation should be used to clearly distinguish itself
  as a continuation line.

Okay: a = (\n)
E123: a = (\n    )

Okay: a = (\n    42)
E121: a = (\n   42)
E122: a = (\n42)
E123: a = (\n    42\n    )
E124: a = (24,\n     42\n)
E125: if (\n    b):\n    pass
E126: a = (\n        42)
E127: a = (24,\n      42)
E128: a = (24,\n    42)
E129: if (a or\n    b):\n    pass
E131: a = (\n    42\n 24)

There are no issues that match your filters.

Category
Status