ejplatform/ej-server

View on GitHub
src/ej_tools/views.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function mautic has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

def mautic(request, board_slug, conversation_id, slug, oauth2_code=None):
    conversation = Conversation.objects.get(id=conversation_id)
    user_signature = SignatureFactory.get_user_signature(conversation.author)
    tool = user_signature.get_tool(_("Mautic"), conversation)
    tool.raise_error_if_not_active()
Severity: Minor
Found in src/ej_tools/views.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function delete_connection has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def delete_connection(request, board_slug, conversation_id, slug, connection_id):
Severity: Minor
Found in src/ej_tools/views.py - About 35 mins to fix

    Function mautic has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def mautic(request, board_slug, conversation_id, slug, oauth2_code=None):
    Severity: Minor
    Found in src/ej_tools/views.py - About 35 mins to fix

      Function delete_mautic_connection has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def delete_mautic_connection(request, board_slug, conversation_id, slug, mautic_connection_id):
      Severity: Minor
      Found in src/ej_tools/views.py - About 35 mins to fix

        Function webchat has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def webchat(request, board_slug, conversation_id, slug):
            conversation = Conversation.objects.get(id=conversation_id)
            user_signature = SignatureFactory.get_user_signature(conversation.author)
            tool = user_signature.get_tool(_("Opinion Bots"), conversation).webchat
            tool.raise_error_if_not_active()
        Severity: Minor
        Found in src/ej_tools/views.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function mailing has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        def mailing(request, board_slug, conversation_id, slug):
            from .mailing import TemplateGenerator
        
            conversation = Conversation.objects.get(id=conversation_id)
            user_signature = SignatureFactory.get_user_signature(conversation.author)
        Severity: Minor
        Found in src/ej_tools/views.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status