Sign upLogin

ekinhbayar/gitamp

View on GitHub
Star

Showing 27 of 27 total issues

Avoid unused parameters such as '$server'.
Open

    public function onStart(HttpServer $server, Gateway $gateway): Promise
Severity: Minor
Found in src/Websocket/Handler.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$request'.
Open

    public function handleClient(Gateway $gateway, Client $client, Request $request, Response $response): Promise
Severity: Minor
Found in src/Websocket/Handler.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\Amp\Http\Client\HttpClientBuilder' in method 'getWebSocket'.
Open

            HttpClientBuilder::buildDefault(),
Severity: Minor
Found in src/Server.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$server'.
Open

    public function onStop(HttpServer $server, Gateway $gateway): Promise
Severity: Minor
Found in src/Websocket/Handler.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$gateway'.
Open

    public function onStop(HttpServer $server, Gateway $gateway): Promise
Severity: Minor
Found in src/Websocket/Handler.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\Amp\Socket\Server' in method 'getSockets'.
Open

            fn (SslServerAddress $address) => SocketServer::listen(
                $address->getUri(),
                (new BindContext())
                    ->withTlsContext((new ServerTlsContext())->withDefaultCertificate($address->getCertificate())),
            ),
Severity: Minor
Found in src/Server.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

TODO found
Open

    continue-on-error: true #TODO: Remove this once we get to a passing baseline
Severity: Minor
Found in .github/workflows/ci.yml by fixme
Severity
Category
Status
Source
Language