Sign upLogin

ekinhbayar/gitamp

View on GitHub
Star
src/Websocket/Handler.php

Summary

Maintainability
A
0 mins
Test Coverage

The class Handler has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
Open

class Handler implements ClientHandler, WebsocketServerObserver
{
    private Gateway $gateway;

    private Listener $provider;
Severity: Minor
Found in src/Websocket/Handler.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

Avoid unused parameters such as '$request'.
Open

    public function handleClient(Gateway $gateway, Client $client, Request $request, Response $response): Promise
Severity: Minor
Found in src/Websocket/Handler.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$server'.
Open

    public function onStop(HttpServer $server, Gateway $gateway): Promise
Severity: Minor
Found in src/Websocket/Handler.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$gateway'.
Open

    public function onStop(HttpServer $server, Gateway $gateway): Promise
Severity: Minor
Found in src/Websocket/Handler.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$server'.
Open

    public function onStart(HttpServer $server, Gateway $gateway): Promise
Severity: Minor
Found in src/Websocket/Handler.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$response'.
Open

    public function handleClient(Gateway $gateway, Client $client, Request $request, Response $response): Promise
Severity: Minor
Found in src/Websocket/Handler.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

There are no issues that match your filters.

Category
Status