Sign upLogin

ekmungai/eloquent-ifrs

View on GitHub
Star

Showing 39 of 66 total issues

Method __construct has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct(string $accountType = Account::RECEIVABLE, string $endDate = null, int $currencyId = null, Entity $entity = null)
    {
        if (is_null($entity)) {
            $this->entity = Auth::user()->entity;
        }else{
Severity: Minor
Found in src/Reports/AgingSchedule.php - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

            if ($transaction->is_credited && $rateDifference < 0 || !$transaction->is_credited && $rateDifference > 0) {
            $post->entry_type = Balance::CREDIT;
            $folio->entry_type = Balance::DEBIT;
        } elseif ($transaction->is_credited && $rateDifference > 0 || !$transaction->is_credited && $rateDifference < 0) {
            $post->entry_type = Balance::DEBIT;
    Severity: Major
    Found in src/Models/Ledger.php - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

              if ($isAsset && $difference > 0 || $isLiability && $difference < 0) {
            $credited = true;
        } elseif ($isAsset && $difference < 0 || $isLiability && $difference > 0) {
            $credited = false;
        }
      Severity: Major
      Found in src/Models/ReportingPeriod.php - About 1 hr to fix

        Function removeLineItem has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function removeLineItem(LineItem $lineItem): void
    {
        if (count($lineItem->ledgers) > 0) {
            throw new PostedTransaction("remove LineItems from");
        }
        Severity: Minor
        Found in src/Models/Transaction.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method allocateAmount has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private static function allocateAmount($postAccount, $amount, $posts, $folios, $transaction, $entryType): bool
        Severity: Minor
        Found in src/Models/Ledger.php - About 45 mins to fix

          Function balanceAccount has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              private function balanceAccount(
        int $forexAccountId,
        Account $account,
        float $localBalance,
        float $foreignBalance,
          Severity: Minor
          Found in src/Models/ReportingPeriod.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function postForex has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function postForex(Assignment $assignment, $transactionRate, $clearedRate): void
    {
        $rateDifference = round($transactionRate - $clearedRate, config('ifrs.forex_scale'));
        $transaction = $assignment->transaction;
          Severity: Minor
          Found in src/Models/Ledger.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method balanceAccount has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  int $forexAccountId,
        Account $account,
        float $localBalance,
        float $foreignBalance,
        Carbon $closingDate,
          Severity: Minor
          Found in src/Models/ReportingPeriod.php - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            <?php

/**
 * Eloquent IFRS Accounting
 *
            Severity: Minor
            Found in src/Exceptions/InvalidBalanceType.php and 1 other location - About 45 mins to fix
            src/Exceptions/InvalidBalanceTransaction.php on lines 1..33

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 95.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            <?php

/**
 * Eloquent IFRS Accounting
 *
            Severity: Minor
            Found in src/Exceptions/InvalidBalanceTransaction.php and 1 other location - About 45 mins to fix
            src/Exceptions/InvalidBalanceType.php on lines 1..33

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 95.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method sectionBalances has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    array $accountTypes,
        $startDate = null,
        $endDate = null,
        $fullBalance = true,
        Entity $entity = null
            Severity: Minor
            Found in src/Models/Account.php - About 35 mins to fix

              Function addVat has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function addVat(Vat $vat): bool
    {
        if (count($this->ledgers) > 0) {
            throw new PostedTransaction("add Vat to");
        }
              Severity: Minor
              Found in src/Models/LineItem.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function openingBalance has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function openingBalance(int $year = null, int $currencyId = null): array
    {
        $entity = $this->entity;

        $balances = [$entity->currency_id => 0];
              Severity: Minor
              Found in src/Models/Account.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function openingBalances has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function openingBalances(int $year, Entity $entity = null)
    {
        if (is_null($entity)) {
            $entity = Auth::user()->entity;
        }
              Severity: Minor
              Found in src/Models/Account.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getVatAttribute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getVatAttribute(): array
    {
        $vats = ['total' => 0];
        foreach ($this->getLineItems() as $lineItem) {
            foreach ($lineItem->vat as $type => $amount)
              Severity: Minor
              Found in src/Models/Transaction.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getSections has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getSections($startDate = null, $endDate = null, $fullbalance = true): array
    {
        foreach (Account::where('entity_id', '=', $this->entity->id)->get() as $account) {
            $balance = $account->closingBalance($this->endDate)[$this->entity->currency_id];
              Severity: Minor
              Found in src/Reports/TrialBalance.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function addLineItem has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function addLineItem(LineItem $lineItem): bool
    {
        if (in_array($lineItem->account->account_type, config('ifrs.single_currency')) && $lineItem->account->currency_id != $this->currency_id) {
            throw new InvalidCurrency("Transaction", $lineItem->account);
        }
              Severity: Minor
              Found in src/Models/Transaction.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function up has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function up()
    {

        Schema::create(
            config('ifrs.table_prefix').'recycled_objects',
              Severity: Minor
              Found in database/migrations/2020_01_10_213405_create_ifrs_recycled_objects_table.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function save has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function save(array $options = []): bool
    {
        if (!is_null($this->rate)) {
            $this->rate = abs($this->rate);
        }
              Severity: Minor
              Found in src/Models/Vat.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language