Sign upLogin

ekmungai/eloquent-ifrs

View on GitHub
Star
src/Models/Ledger.php

Summary

Maintainability
A
3 hrs
Test Coverage
A
97%

Method allocateAmount has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function allocateAmount($postAccount, $amount, $posts, $folios, $transaction, $entryType): bool
    {
        if ($amount == 0) {
            $key = array_key_first($posts);
            unset($posts[$key]);
Severity: Minor
Found in src/Models/Ledger.php - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

            if ($transaction->is_credited && $rateDifference < 0 || !$transaction->is_credited && $rateDifference > 0) {
            $post->entry_type = Balance::CREDIT;
            $folio->entry_type = Balance::DEBIT;
        } elseif ($transaction->is_credited && $rateDifference > 0 || !$transaction->is_credited && $rateDifference < 0) {
            $post->entry_type = Balance::DEBIT;
    Severity: Major
    Found in src/Models/Ledger.php - About 1 hr to fix

      Method allocateAmount has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private static function allocateAmount($postAccount, $amount, $posts, $folios, $transaction, $entryType): bool
      Severity: Minor
      Found in src/Models/Ledger.php - About 45 mins to fix

        Function postForex has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function postForex(Assignment $assignment, $transactionRate, $clearedRate): void
    {
        $rateDifference = round($transactionRate - $clearedRate, config('ifrs.forex_scale'));
        $transaction = $assignment->transaction;
        Severity: Minor
        Found in src/Models/Ledger.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status