Sign upLogin

ekmungai/eloquent-ifrs

View on GitHub
Star
src/Models/ReportingPeriod.php

Summary

Maintainability
C
1 day
Test Coverage
A
97%

Function prepareBalancesTranslation has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public function prepareBalancesTranslation($forexAccountId, int $accountId = null): array
    {

        if (Account::find($forexAccountId)->account_type != Account::EQUITY) {
            throw new InvalidAccountType('Transaltion Forex', Account::EQUITY);
Severity: Minor
Found in src/Models/ReportingPeriod.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method prepareBalancesTranslation has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function prepareBalancesTranslation($forexAccountId, int $accountId = null): array
    {

        if (Account::find($forexAccountId)->account_type != Account::EQUITY) {
            throw new InvalidAccountType('Transaltion Forex', Account::EQUITY);
Severity: Minor
Found in src/Models/ReportingPeriod.php - About 1 hr to fix

    Method balanceAccount has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function balanceAccount(
        int $forexAccountId,
        Account $account,
        float $localBalance,
        float $foreignBalance,
    Severity: Minor
    Found in src/Models/ReportingPeriod.php - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

              if ($isAsset && $difference > 0 || $isLiability && $difference < 0) {
            $credited = true;
        } elseif ($isAsset && $difference < 0 || $isLiability && $difference > 0) {
            $credited = false;
        }
      Severity: Major
      Found in src/Models/ReportingPeriod.php - About 1 hr to fix

        Function balanceAccount has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private function balanceAccount(
        int $forexAccountId,
        Account $account,
        float $localBalance,
        float $foreignBalance,
        Severity: Minor
        Found in src/Models/ReportingPeriod.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method balanceAccount has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                int $forexAccountId,
        Account $account,
        float $localBalance,
        float $foreignBalance,
        Carbon $closingDate,
        Severity: Minor
        Found in src/Models/ReportingPeriod.php - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status