Sign upLogin

ekonstantinidis/trevor

View on GitHub
Star

Showing 10 of 10 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      if (pro == 'false' || pro === false) {
        console.log('REQUEST: IS NOT PRO');
        domain = 'https://api.travis-ci.org';
        host = 'api.travis-ci.org';
      } else if (pro == 'true' || pro === true) {
Severity: Major
Found in www/js/services/request.js and 1 other location - About 3 hrs to fix
www/js/services/request.js on lines 12..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      if (pro == 'false' || pro === false) {
        console.log('REQUEST: IS NOT PRO');
        domain = 'https://api.travis-ci.org';
        host = 'api.travis-ci.org';
      } else if (pro == 'true' || pro === true) {
Severity: Major
Found in www/js/services/request.js and 1 other location - About 3 hrs to fix
www/js/services/request.js on lines 64..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function exports has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(config) {
  config.set({

    // base path that will be used to resolve all patterns (eg. files, exclude)
    basePath: '',
Severity: Minor
Found in karma.conf.js - About 1 hr to fix

    Function requestLog has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        requestLog: function (url, pro) {

      var deferred = $q.defer();

      var domain, host;
    Severity: Minor
    Found in www/js/services/request.js - About 1 hr to fix

      Function request has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          request: function (method, url, pro, data) {

      var deferred = $q.defer();

      var domain, host;
      Severity: Minor
      Found in www/js/services/request.js - About 1 hr to fix

        Function fetch has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          $scope.fetch = function() {

    LoadingService.show();

    RequestService
        Severity: Minor
        Found in www/js/controllers/log.js - About 1 hr to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                if ((pro == 'true' || pro === true) && url != '/auth/github') {
        var tokenPro = AccountsService.tokens.pro;
        headers.Authorization = 'token ' + tokenPro;
      }
          Severity: Major
          Found in www/js/services/request.js and 2 other locations - About 1 hr to fix
          www/js/services/request.js on lines 36..39
          www/js/services/request.js on lines 84..87

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                if ((pro == 'true' || pro === true) && url != '/auth/github') {
        var tokenPro = AccountsService.tokens.pro;
        headers.Authorization = 'token ' + tokenPro;
      }
          Severity: Major
          Found in www/js/services/request.js and 2 other locations - About 1 hr to fix
          www/js/services/request.js on lines 31..34
          www/js/services/request.js on lines 36..39

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                if ((pro == 'false' || pro === false) && url == '/accounts?all=true') {
        var tokenOs = AccountsService.tokens.os;
        headers.Authorization = 'token ' + tokenOs;
      }
          Severity: Major
          Found in www/js/services/request.js and 2 other locations - About 1 hr to fix
          www/js/services/request.js on lines 31..34
          www/js/services/request.js on lines 84..87

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function fetchData has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            $scope.fetchData = function() {
    $scope.repos = [];

    if (favourites.length > 0) {
      LoadingService.show();
          Severity: Minor
          Found in www/js/controllers/favourites.js - About 1 hr to fix
            Severity
            Category
            Status
            Source
            Language