ekristen/gcp-nuke

View on GitHub

Showing 28 of 55 total issues

Method VPCIPAddress.HandleWait has 5 return statements (exceeds 4 allowed).
Open

func (r *VPCIPAddress) HandleWait(ctx context.Context) error {
    if r.removeOp == nil {
        return nil
    }

Severity: Major
Found in resources/vpc-ip-address.go - About 35 mins to fix

    Method IAMServiceAccountKeyLister.List has 5 return statements (exceeds 4 allowed).
    Open

    func (l *IAMServiceAccountKeyLister) List(ctx context.Context, o interface{}) ([]resource.Resource, error) {
        var resources []resource.Resource
    
        opts := o.(*nuke.ListerOpts)
        if err := opts.BeforeList(nuke.Global, "iam.googleapis.com"); err != nil {
    Severity: Major
    Found in resources/iam-service-account-key.go - About 35 mins to fix

      Method ComputeURLMap.HandleWait has 5 return statements (exceeds 4 allowed).
      Open

      func (r *ComputeURLMap) HandleWait(ctx context.Context) error {
          if r.removeOp == nil {
              return nil
          }
      
      
      Severity: Major
      Found in resources/compute-url-map.go - About 35 mins to fix

        Method ComputeTargetHTTPProxy.HandleWait has 5 return statements (exceeds 4 allowed).
        Open

        func (r *ComputeTargetHTTPProxy) HandleWait(ctx context.Context) error {
            if r.removeOp == nil {
                return nil
            }
        
        
        Severity: Major
        Found in resources/compute-target-http-proxy.go - About 35 mins to fix

          Method DNSManagedZoneLister.List has 5 return statements (exceeds 4 allowed).
          Open

          func (l *DNSManagedZoneLister) List(ctx context.Context, o interface{}) ([]resource.Resource, error) {
              opts := o.(*nuke.ListerOpts)
              var resources []resource.Resource
          
              if err := opts.BeforeList(nuke.Global, "dns.googleapis.com"); err != nil {
          Severity: Major
          Found in resources/dns-managed-zone.go - About 35 mins to fix

            Method IAMWorkloadIdentityPoolProviderLister.List has 5 return statements (exceeds 4 allowed).
            Open

            func (l *IAMWorkloadIdentityPoolProviderLister) List(ctx context.Context, o interface{}) ([]resource.Resource, error) {
                var resources []resource.Resource
            
                opts := o.(*nuke.ListerOpts)
                if err := opts.BeforeList(nuke.Global, "iam.googleapis.com"); err != nil {
            Severity: Major
            Found in resources/iam-workload-identity-pool-provider.go - About 35 mins to fix

              Function execute has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
              Open

              func execute(c *cli.Context) error {
                  ctx, cancel := context.WithCancel(c.Context)
                  defer cancel()
              
                  gcp, err := gcputil.New(ctx, c.String("project-id"), c.String("impersonate-service-account"))
              Severity: Minor
              Found in pkg/commands/run/command.go - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function New has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
              Open

              func New(ctx context.Context, projectID, impersonateServiceAccount string) (*GCP, error) {
                  gcp := &GCP{
                      Organizations: make([]*Organization, 0),
                      Projects:      make([]*Project, 0),
                      Regions:       []string{"global"},
              Severity: Minor
              Found in pkg/gcputil/gcp.go - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language