elabftw/elabftw

View on GitHub

Showing 356 of 356 total issues

Avoid too many return statements within this function.
Open

        return handleDate();
Severity: Major
Found in src/ts/search.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return handleDate();
    Severity: Major
    Found in src/ts/search.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return true;
      Severity: Major
      Found in src/ts/Metadata.class.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return handleMetadata();
        Severity: Major
        Found in src/ts/search.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return;
          Severity: Major
          Found in src/ts/show.ts - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                private function update(TeamParam $params): bool
                {
                    $sql = 'UPDATE teams SET ' . $params->getColumn() . ' = :content WHERE id = :id';
                    $req = $this->Db->prepare($sql);
                    $req->bindValue(':content', $params->getContent());
            Severity: Minor
            Found in src/models/Teams.php and 1 other location - About 30 mins to fix
            src/models/ProcurementRequests.php on lines 131..138

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function getRows has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function getRows(): array
                {
                    $rows = array();
                    foreach ($this->idArr as $id) {
                        try {
            Severity: Minor
            Found in src/Make/MakeCsv.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getAuthType has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private function getAuthType(): string
                {
                    // try to login with the elabid for an entity in view mode
                    $page = basename($this->Request->getScriptName());
                    if ($this->Request->query->has('access_key')
            Severity: Minor
            Found in src/classes/Auth.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function sendEmails has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function sendEmails(): int
                {
                    $toSend = $this->getNotificationsToSend();
                    foreach ($toSend as $notif) {
                        $targetUser = new Users($notif['userid']);
            Severity: Minor
            Found in src/services/EmailNotifications.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function execute(InputInterface $input, OutputInterface $output)
                {
                    $output->writeln(array(
                        'Checking uploads',
                        '================',
            Severity: Minor
            Found in src/commands/CheckUploads.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getResponse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getResponse(): Response
                {
                    try {
                        $this->parseReq();
            
            
            Severity: Minor
            Found in src/controllers/Apiv2Controller.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function sendAdminsEmails has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function sendAdminsEmails(array $targets): int
                {
                    $emailSubject = _('Account expiration information');
                    $cnt = 0;
                    // loop on each team
            Severity: Minor
            Found in src/services/ExpirationNotifier.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function findOrphans has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private function findOrphans(): array
                {
                    $orphans = array();
                    $contents = $this->filesystem->listContents('', true);
                    foreach ($contents as $file) {
            Severity: Minor
            Found in src/services/UploadsCleaner.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function sorter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              sorter(items) {
                const customId = [];
                const beginswith = [];
                const caseSensitive = [];
                const caseInsensitive = [];
            Severity: Minor
            Found in src/js/tinymce-plugins/mention/plugin.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function triggerHandler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function triggerHandler(event: Event, el: HTMLInputElement): void {
              const ApiC = new Api();
              event.preventDefault();
              el.classList.remove('is-invalid');
              // for a checkbox element, look at the checked attribute, not the value
            Severity: Minor
            Found in src/ts/misc.ts - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getEntity has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            export function getEntity(): Entity {
              if (!document.getElementById('info')) {
                return;
              }
              // holds info about the page through data attributes
            Severity: Minor
            Found in src/ts/misc.ts - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language