Sign upLogin

elabftw/elabftw

View on GitHub
Star
src/controllers/Apiv2Controller.php

Summary

Maintainability
C
1 day
Test Coverage

File Apiv2Controller.php has 283 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * @author Nicolas CARPi <nico-git@deltablot.email>
 * @copyright 2022 Nicolas CARPi
Severity: Minor
Found in src/controllers/Apiv2Controller.php - About 2 hrs to fix

    Method getSubModel has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getSubModel(string $submodel): RestInterface
    {
        if ($this->Model instanceof AbstractEntity) {
            $Config = Config::getConfig();
            return match ($submodel) {
    Severity: Minor
    Found in src/controllers/Apiv2Controller.php - About 1 hr to fix

      Method getResponse has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getResponse(): Response
    {
        try {
            $this->parseReq();
      Severity: Minor
      Found in src/controllers/Apiv2Controller.php - About 1 hr to fix

        Method getModel has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function getModel(): RestInterface
    {
        return match ($this->endpoint) {
            ApiEndpoint::ApiKeys => new ApiKeys($this->Users, $this->id),
            ApiEndpoint::Config => Config::getConfig(),
        Severity: Minor
        Found in src/controllers/Apiv2Controller.php - About 1 hr to fix

          Function parseReq has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function parseReq(): array
    {
        $req = parent::parseReq();
        // load Model
        $this->Model = $this->getModel();
          Severity: Minor
          Found in src/controllers/Apiv2Controller.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method parseReq has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function parseReq(): array
    {
        $req = parent::parseReq();
        // load Model
        $this->Model = $this->getModel();
          Severity: Minor
          Found in src/controllers/Apiv2Controller.php - About 1 hr to fix

            Avoid too many return statements within this method.
            Open

                        return new JsonResponse($error, $error['code']);
            Severity: Major
            Found in src/controllers/Apiv2Controller.php - About 30 mins to fix

              Function getResponse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getResponse(): Response
    {
        try {
            $this->parseReq();
              Severity: Minor
              Found in src/controllers/Apiv2Controller.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status