elabftw/elabftw

View on GitHub
src/models/Config.php

Summary

Maintainability
C
1 day
Test Coverage

Method create has 130 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function create(): bool
    {
        $schema = Update::getRequiredSchema();

        $sql = "INSERT INTO `config` (`conf_name`, `conf_value`) VALUES
Severity: Major
Found in src/models/Config.php - About 5 hrs to fix

    File Config.php has 257 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    /**
     * @author Nicolas CARPi <nico-git@deltablot.email>
     * @copyright 2012 Nicolas CARPi
    Severity: Minor
    Found in src/models/Config.php - About 2 hrs to fix

      Function patch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function patch(Action $action, array $params): array
          {
              $passwords = array('smtp_password', 'ldap_password', 'ts_password', 'remote_dir_config');
      
              foreach ($passwords as $password) {
      Severity: Minor
      Found in src/models/Config.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status