elabftw/elabftw

View on GitHub
src/services/advancedSearchQuery/visitors/QueryBuilderVisitor.php

Summary

Maintainability
D
2 days
Test Coverage

File QueryBuilderVisitor.php has 401 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * @author Nicolas CARPi <nico-git@deltablot.email>
 * @author Marcel Bolten <github@marcelbolten.de>
Severity: Minor
Found in src/services/advancedSearchQuery/visitors/QueryBuilderVisitor.php - About 5 hrs to fix

    QueryBuilderVisitor has 29 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class QueryBuilderVisitor implements Visitor
    {
        public function buildWhere(Visitable $parsedQuery, VisitorParameters $parameters): WhereCollector
        {
            return $parsedQuery->accept($this, $parameters);
    Severity: Minor
    Found in src/services/advancedSearchQuery/visitors/QueryBuilderVisitor.php - About 3 hrs to fix

      Method visitTimestampField has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function visitTimestampField(TimestampField $timestampField, VisitorParameters $parameters): WhereCollector
          {
              $query = '';
              $bindValues = array();
      
      
      Severity: Major
      Found in src/services/advancedSearchQuery/visitors/QueryBuilderVisitor.php - About 2 hrs to fix

        Function visitTimestampField has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public function visitTimestampField(TimestampField $timestampField, VisitorParameters $parameters): WhereCollector
            {
                $query = '';
                $bindValues = array();
        
        
        Severity: Minor
        Found in src/services/advancedSearchQuery/visitors/QueryBuilderVisitor.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method visitDateField has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function visitDateField(DateField $dateField, VisitorParameters $parameters): WhereCollector
            {
                $query = '';
                $bindValues = array();
        
        
        Severity: Minor
        Found in src/services/advancedSearchQuery/visitors/QueryBuilderVisitor.php - About 1 hr to fix

          Method visitSimpleValueWrapper has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function visitSimpleValueWrapper(SimpleValueWrapper $simpleValueWrapper, VisitorParameters $parameters): WhereCollector
              {
                  $param = $this->getUniqueID();
                  $paramBody = $this->getUniqueID();
                  $paramCustomId = $this->getUniqueID();
          Severity: Minor
          Found in src/services/advancedSearchQuery/visitors/QueryBuilderVisitor.php - About 1 hr to fix

            Method visitMetadataField has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function visitMetadataField(MetadataField $metadataField, VisitorParameters $parameters): WhereCollector
                {
                    $pathParam = $this->getUniqueID();
                    $valueParam = $this->getUniqueID();
                    $column = 'entity.metadata';
            Severity: Minor
            Found in src/services/advancedSearchQuery/visitors/QueryBuilderVisitor.php - About 1 hr to fix

              There are no issues that match your filters.

              Category
              Status