elabftw/elabftw

File edit.ts has 329 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/**
 * @author Nicolas CARPi <nico-git@deltablot.email>
 * @copyright 2012 Nicolas CARPi
 * @see https://www.elabftw.net Official website
 * @license AGPL-3.0

Function imagesUploadHandler has 40 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    const imagesUploadHandler = (blobInfo): Promise<string> => new Promise((resolve, reject) => {
      // Edgecase for editing an image using tinymce ImageTools
      // Check if it was selected. This is set by an event hook below
      if (tinymceEditImage.selected === true) {
        // Note: confirm will trigger the SelectionChange event hook below again

Avoid deeply nested control flow statements.

Open

        if (editor.type === 'md') {
          content = `[${json.body}](?mode=view&id=${entity.id}&highlightstep=${el.dataset.stepid}#step_view_${el.dataset.stepid})`;
        }

Avoid deeply nested control flow statements.

Open

    } else if (el.matches('[data-action="insert-image-in-body"]')) {
      // link to the image
      const url = `app/download.php?name=${el.dataset.name}&f=${el.dataset.link}&storage=${el.dataset.storage}`;
      // switch for markdown or tinymce editor
      let content: string;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  $(document).on('change', '.catstatSelect', function() {
    updateCatStat($(this).data('target'), entity, String($(this).val()));
  });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      ApiC.post(`${entity.type}/${entity.id}/${Model.Upload}`, params).then(() => reloadElements(['uploadsDiv']));

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

      ApiC.getJson(`${entity.type}/${entity.id}/${Model.Step}/${el.dataset.stepid}`).then(json => {
        let content = `<a href='?mode=view&id=${entity.id}&highlightstep=${el.dataset.stepid}#step_view_${el.dataset.stepid}'>${json.body}</a>`;
        // markdown
        if (editor.type === 'md') {
          content = `[${json.body}](?mode=view&id=${entity.id}&highlightstep=${el.dataset.stepid}#step_view_${el.dataset.stepid})`;

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            return ApiC.getJson(`${entity.type}/${entity.id}/${Model.Upload}/${newId}`).then(json => {
              resolve(`app/download.php?f=${json.long_name}&storage=${json.storage}`);
              // save here because using the old real_name will not return anything from the db (status is archived now)
              updateEntityBody();
              reloadElements(['uploadsDiv']);

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        ApiC.getJson(`${entity.type}/${entity.id}/${Model.Upload}/${newId}`).then(json => {
          // use regExp in replace to find all occurrence
          // images are identified by 'src="app/download.php?f=' (html) and '![image](app/download.php?f=' (md)
          // '.', '?', '[' and '(' need to be escaped in js regex
          const editorNewContent = editorCurrentContent.replace(

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

          content = `[${json.body}](?mode=view&id=${entity.id}&highlightstep=${el.dataset.stepid}#step_view_${el.dataset.stepid})`;

• Read up
  Read up