elabftw/elabftw

View on GitHub
src/ts/show.ts

Summary

Maintainability
D
2 days
Test Coverage

File show.ts has 321 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * @author Nicolas CARPi <nico-git@deltablot.email>
 * @copyright 2012 Nicolas CARPi
 * @see https://www.elabftw.net Official website
 * @license AGPL-3.0
Severity: Minor
Found in src/ts/show.ts - About 3 hrs to fix

    Avoid deeply nested control flow statements.
    Open

            if (id === 'withSelected' && scroll && el.getBoundingClientRect().bottom > 0) {
              window.scrollBy({top: el.offsetHeight, behavior: 'instant'});
            }
    Severity: Major
    Found in src/ts/show.ts - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

            if ((el as HTMLInputElement).checked) {
              (el.closest('.entity') as HTMLElement).style.backgroundColor = bgColor;
            } else {
              (el.closest('.entity') as HTMLElement).style.backgroundColor = '';
            }
      Severity: Major
      Found in src/ts/show.ts - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

            } else if (el.matches('[data-action="expand-all-entities"]')) {
              event.preventDefault();
              if (el.dataset.status === 'closed') {
                el.dataset.status = 'opened';
                el.innerText = el.dataset.collapse;
        Severity: Major
        Found in src/ts/show.ts - About 45 mins to fix

          Avoid too many return statements within this function.
          Open

                  return;
          Severity: Major
          Found in src/ts/show.ts - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                } else if (el.matches('[data-action="lock-selected-entities"]')) {
                  // get the item id of all checked boxes
                  const checked = getCheckedBoxes();
                  if (checked.length === 0) {
                    notif(nothingSelectedError);
            Severity: Major
            Found in src/ts/show.ts and 1 other location - About 4 hrs to fix
            src/ts/show.ts on lines 379..411

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 128.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                } else if (el.matches('[data-action="archive-selected-entities"]')) {
                  // get the item id of all checked boxes
                  const checked = getCheckedBoxes();
                  if (checked.length === 0) {
                    notif(nothingSelectedError);
            Severity: Major
            Found in src/ts/show.ts and 1 other location - About 4 hrs to fix
            src/ts/show.ts on lines 347..411

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 128.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  ['advancedSelectOptions', 'withSelected'].forEach(id => {
                    document.getElementById(id).classList.remove('d-none');
                  });
            Severity: Minor
            Found in src/ts/show.ts and 1 other location - About 35 mins to fix
            src/ts/show.ts on lines 329..331

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  ['advancedSelectOptions', 'withSelected'].forEach(id => {
                    document.getElementById(id).classList.add('d-none');
                  });
            Severity: Minor
            Found in src/ts/show.ts and 1 other location - About 35 mins to fix
            src/ts/show.ts on lines 317..319

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                } else if (el.matches('[data-action="destroy-favtags"]')) {
                  FavTagC.destroy(parseInt(el.dataset.id, 10)).then(() => reloadElements(['favtagsTagsDiv']));
            
                // SORT COLUMN IN TABULAR MODE
                } else if (el.matches('[data-action="reorder-entities"]')) {
            Severity: Minor
            Found in src/ts/show.ts and 1 other location - About 35 mins to fix
            src/ts/steps-links.ts on lines 43..74

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status