Sign upLogin

elboletaire/Watimage

View on GitHub
Star

Showing 57 of 57 total issues

File Image.php has 604 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace Elboletaire\Watimage;

use Exception;
use Elboletaire\Watimage\Exception\ExtensionNotLoadedException;
Severity: Major
Found in src/Image.php - About 1 day to fix

    Image has 50 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Image
{
    /**
     * Constant for the (deprecated) transparent color
     */
    Severity: Minor
    Found in src/Image.php - About 7 hrs to fix

      The class Image has 37 public methods. Consider refactoring Image to keep number of public methods under 10.
      Open

      class Image
{
    /**
     * Constant for the (deprecated) transparent color
     */
      Severity: Minor
      Found in src/Image.php by phpmd

      TooManyPublicMethods

      Since: 0.1

      A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

      By default it ignores methods starting with 'get' or 'set'.

      Example

      Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

      The class Image has 42 non-getter- and setter-methods. Consider refactoring Image to keep number of methods under 25.
      Open

      class Image
{
    /**
     * Constant for the (deprecated) transparent color
     */
      Severity: Minor
      Found in src/Image.php by phpmd

      TooManyMethods

      Since: 0.1

      A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

      By default it ignores methods starting with 'get' or 'set'.

      The default was changed from 10 to 25 in PHPMD 2.3.

      Example

      Source https://phpmd.org/rules/codesize.html#toomanymethods

      The class Image has an overall complexity of 123 which is very high. The configured complexity threshold is 50.
      Open

      class Image
{
    /**
     * Constant for the (deprecated) transparent color
     */
      Severity: Minor
      Found in src/Image.php by phpmd

      The class Normalize has an overall complexity of 72 which is very high. The configured complexity threshold is 50.
      Open

      class Normalize
{
    /**
     * Returns the proper color array for the given color.
     *
      Severity: Minor
      Found in src/Normalize.php by phpmd

      Function calculateSize has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function calculateSize($metadata)
    {
        if (!isset($this->size)) {
            return;
        }
      Severity: Minor
      Found in src/Watermark.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method color has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function color($color)
    {
        if ($color === Image::COLOR_TRANSPARENT) {
            return [
                'r' => 0,
      Severity: Major
      Found in src/Normalize.php - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (preg_match('/bottom/', $this->position)) {
            $y = $metadata['height'] - $this->height  + $this->margin[1];
        } elseif (preg_match('/top/', $this->position)) {
            $y = 0  + $this->margin[1];
        } elseif (preg_match('/center/', $this->position)) {
        Severity: Major
        Found in src/Watermark.php and 1 other location - About 2 hrs to fix
        src/Watermark.php on lines 182..188

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 128.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (preg_match('/right/', $this->position)) {
            $x = $metadata['width'] - $this->width + $this->margin[0];
        } elseif (preg_match('/left/', $this->position)) {
            $x = 0  + $this->margin[0];
        } elseif (preg_match('/center/', $this->position)) {
        Severity: Major
        Found in src/Watermark.php and 1 other location - About 2 hrs to fix
        src/Watermark.php on lines 191..197

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 128.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        File Normalize.php has 260 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
namespace Elboletaire\Watimage;

use Elboletaire\Watimage\Exception\InvalidArgumentException;
        Severity: Minor
        Found in src/Normalize.php - About 2 hrs to fix

          Function size has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function size($width, $height = null)
    {
        if (!isset($height) && is_array($width)) {
            $allowedKeys = [
                [0, 1],
          Severity: Minor
          Found in src/Normalize.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function color has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function color($color)
    {
        if ($color === Image::COLOR_TRANSPARENT) {
            return [
                'r' => 0,
          Severity: Minor
          Found in src/Normalize.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method calculateSize has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function calculateSize($metadata)
    {
        if (!isset($this->size)) {
            return;
        }
          Severity: Minor
          Found in src/Watermark.php - About 1 hr to fix

            Method cropMeasures has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function cropMeasures($ox, $oy = null, $dx = null, $dy = null)
    {
        if (!isset($oy, $dx, $dy, $width, $height) && is_array($ox)) {
            $values = $ox;
            $allowedKeys = [
            Severity: Minor
            Found in src/Normalize.php - About 1 hr to fix

              Method size has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public static function size($width, $height = null)
    {
        if (!isset($height) && is_array($width)) {
            $allowedKeys = [
                [0, 1],
              Severity: Minor
              Found in src/Normalize.php - About 1 hr to fix

                Function position has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function position($x, $y = null)
    {
        if (is_array($x)) {
            if (isset($x['x']) || isset($x['y'])) {
                extract($x);
                Severity: Minor
                Found in src/Normalize.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method convenienceFlip has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function convenienceFlip($type = 'horizontal')
    {
        $type = Normalize::flip($type);

        $resampled = $this->imagecreate($this->width, $this->height);
                Severity: Minor
                Found in src/Image.php - About 1 hr to fix

                  Method crop has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public static function crop($x, $y = null, $width = null, $height = null)
    {
        if (!isset($y, $width, $height) && is_array($x)) {
            $values = $x;
            $allowedKeys = [
                  Severity: Minor
                  Found in src/Normalize.php - About 1 hr to fix

                    Function calculatePosition has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function calculatePosition($metadata)
    {
        // Force center alignement if 'full' size has been set
        if ($this->size == 'full') {
            $this->position = 'center center';
                    Severity: Minor
                    Found in src/Watermark.php - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language