Sign upLogin

elcodedocle/chbspassgen

View on GitHub
Star
PasswordGeneratorAbstract.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function getMinSymbolCount has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function getMinSymbolCount($minEntropy = null, $dictionary = null, $variationsCount = null){
        if ($variationsCount === null) { $variationsCount = $this->getVariationsCount(); }
        else if (!is_int($variationsCount)) { throw new Exception ('$variationsCount must be an int'); }
        if ($minEntropy === null) { $minEntropy = $this->getMinEntropy(); }
        else if (!is_numeric($minEntropy)) { throw new Exception ('$minEntropy must be numeric'); }
Severity: Minor
Found in PasswordGeneratorAbstract.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getEntropy has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function getEntropy($password = '', $dictionary = null, $variationsCount = null, $lastOrSeparator = true, $separatorsCount = null){
        if ($variationsCount === null) { $variationsCount = $this->getVariationsCount(); }
        if ($separatorsCount === null) { $separatorsCount = ($lastOrSeparator!==false)?$this->getSeparatorsCount():1; }
        else if (!is_int($variationsCount)) { throw new Exception ('$variationsCount must be an int'); }
        if ($dictionary===null) {
Severity: Minor
Found in PasswordGeneratorAbstract.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getEntropy has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function getEntropy($password = '', $dictionary = null, $variationsCount = null, $lastOrSeparator = true, $separatorsCount = null){
Severity: Minor
Found in PasswordGeneratorAbstract.php - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status