eldr-rb/eldr-responders

View on GitHub

Showing 5 of 5 total issues

Method action has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def action
        action   = @options[:action]
        action ||= env['eldr.route'].name

        if action.nil?
Severity: Minor
Found in lib/eldr/responders/response.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method message has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def message
        return @options[:message]         if @options[:message]
        return @options[:error_message]   if @options[:error_message]   and !valid?
        return @options[:success_message] if @options[:success_message] and valid?

Severity: Minor
Found in lib/eldr/responders/response.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

          return t.responder.send(plural_model_name).send(action, human_model_name)
Severity: Major
Found in lib/eldr/responders/response.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

              return t.responder.send(plural_model_name).send(action, human_model_name)
    Severity: Major
    Found in lib/eldr/responders/response.rb - About 30 mins to fix

      Method valid? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def valid?
              valid = true
      
              obj = object.first if object.is_a? Array
              obj ||= object
      Severity: Minor
      Found in lib/eldr/responders/response.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language