Sign upLogin

elephantly/AmpConverterBundle

View on GitHub
Star

Showing 164 of 164 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function callback()
    {

        foreach ($this->inputElement->childNodes as $tag) {
Severity: Major
Found in Converter/Media/AmpAudioConverter.php and 1 other location - About 3 hrs to fix
Converter/Media/AmpVideoConverter.php on lines 41..61

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 147.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function callback()
    {

        foreach ($this->inputElement->childNodes as $tag) {
Severity: Major
Found in Converter/Media/AmpVideoConverter.php and 1 other location - About 3 hrs to fix
Converter/Media/AmpAudioConverter.php on lines 35..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 147.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method callback has 81 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function callback()
    {
        switch ($this->outputElement->getAttribute('data-do')) {
            case 'embedPin':
                if (!$this->outputElement->getAttribute('data-url')) {
Severity: Major
Found in Converter/Social/AmpPinterestConverter.php - About 3 hrs to fix

    Function callback has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public function callback()
    {
        switch ($this->outputElement->getAttribute('data-do')) {
            case 'embedPin':
                if (!$this->outputElement->getAttribute('data-url')) {
    Severity: Minor
    Found in Converter/Social/AmpPinterestConverter.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid excessively long variable names like $attributeDefaultValue. Keep variable name length under 20.
    Open

                    if ($attributeDefaultValue = $this->getDefaultValue($mandatoryAttribute, $this->inputElement)) {
    Severity: Minor
    Found in Converter/AmpTagConverter.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Method getConfigTreeBuilder has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getConfigTreeBuilder()
    {
        $treeBuilder = new TreeBuilder();
        $rootNode = $treeBuilder->root('elephantly_amp_converter');
    Severity: Minor
    Found in DependencyInjection/Configuration.php - About 1 hr to fix

      Function convertToAmp has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public function convertToAmp($element)
    {
        // Initialize
        $this->inputElement = $element;
        $this->isInputValid = true;
      Severity: Minor
      Found in Converter/AmpTagConverter.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function callback has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function callback()
    {
        $this->outputElement->setAttribute('sandbox', isset($this->options['sandbox']) ? $this->options['sandbox'] : '');

        if (!AmpDimensionsCleaner::isLegal($this->outputElement->getAttribute('width'))) {
      Severity: Minor
      Found in Converter/Layout/AmpIframeConverter.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function convert has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function convert($input)
    {
        if (!$input) {
            return '';
        }
      Severity: Minor
      Found in Converter/AmpConverter.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function callback has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function callback()
    {
        $src = $this->inputElement->getAttribute('data-href');
        preg_match('/https:\/\/www.facebook\.com\/\w*\/(\w*)\/\d*/', $src, $embedType);
        switch ($embedType) {
      Severity: Minor
      Found in Converter/Social/AmpFacebookSdkConverter.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method callback has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function callback()
    {
        $src = $this->inputElement->getAttribute('data-href');
        preg_match('/https:\/\/www.facebook\.com\/\w*\/(\w*)\/\d*/', $src, $embedType);
        switch ($embedType) {
      Severity: Minor
      Found in Converter/Social/AmpFacebookSdkConverter.php - About 1 hr to fix

        Method convert has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function convert($input)
    {
        if (!$input) {
            return '';
        }
        Severity: Minor
        Found in Converter/AmpConverter.php - About 1 hr to fix

          Function callback has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function callback()
    {
        $isConsistent = (AmpDimensionsCleaner::isLegal($this->outputElement->getAttribute('width')) && AmpDimensionsCleaner::isLegal($this->outputElement->getAttribute('height')));

        if (!$isConsistent) {
          Severity: Minor
          Found in Converter/Media/AmpDailymotionIframeConverter.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function callback()
    {
        $isConsistent = (AmpDimensionsCleaner::isLegal($this->inputElement->getAttribute('width')) && AmpDimensionsCleaner::isLegal($this->inputElement->getAttribute('height')));

        if (!$isConsistent) {
          Severity: Minor
          Found in Converter/Media/AmpImgConverter.php and 1 other location - About 35 mins to fix
          Converter/Media/AmpYoutubeIframeConverter.php on lines 57..67

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 92.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function callback()
    {

        $isConsistent = (AmpDimensionsCleaner::isLegal($this->outputElement->getAttribute('width')) && AmpDimensionsCleaner::isLegal($this->outputElement->getAttribute('height')));
          Severity: Minor
          Found in Converter/Media/AmpYoutubeIframeConverter.php and 1 other location - About 35 mins to fix
          Converter/Media/AmpImgConverter.php on lines 63..71

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 92.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Blank line found at start of control structure
          Open

                  foreach ($this->inputElement->childNodes as $tag) {
          Severity: Minor
          Found in Converter/Media/AmpAudioConverter.php by phpcodesniffer

          Function closing brace must go on the next line following the body; found 1 blank lines before brace
          Open

              }
          Severity: Minor
          Found in Converter/Social/AmpFacebookIframeConverter.php by phpcodesniffer

          Expected 0 spaces before closing bracket; 1 found
          Open

                      if (!$hasAttribute || ($hasAttribute && empty($attributeValue)) ) {
          Severity: Minor
          Found in Converter/AmpTagConverter.php by phpcodesniffer

          The closing brace for the class must go on the next line after the body
          Open

          }
          Severity: Minor
          Found in Converter/Social/AmpInstagramConverter.php by phpcodesniffer

          Expected 1 space after FUNCTION keyword; 0 found
          Open

          Filter::register('kahlan.coverage-exporter', function($chain) {
          Severity: Minor
          Found in kahlan-config.travis.php by phpcodesniffer
          Severity
          Category
          Status
          Source
          Language