Sign upLogin

elephantly/AmpConverterBundle

View on GitHub
Star

Showing 25 of 164 total issues

Avoid too many return statements within this method.
Open

                return null;
Severity: Major
Found in Converter/Social/AmpTwitterConverter.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return null;
    Severity: Major
    Found in Converter/Media/AmpDailymotionIframeConverter.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return 315;
      Severity: Major
      Found in Converter/Media/AmpYoutubeIframeConverter.php - About 30 mins to fix

        Function callback has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function callback()
    {
        $src = $this->inputElement->getAttribute('src');
        $brightcoveUrl = parse_url($src);
        $brightcovePath = explode('/', $brightcoveUrl['path']);
        Severity: Minor
        Found in Converter/Media/AmpBrightcoveIframeConverter.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getAmpTagName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getAmpTagName()
    {
        if ( (isset($this->options['amp_anim']) && $this->options['amp_anim']) || !isset($this->options['amp_anim'])) {
            if ($this->inputElement && preg_match('/.*\.gif[?]*/', $this->inputElement->getAttribute('src'))) {
                return 'amp-anim';
        Severity: Minor
        Found in Converter/Media/AmpImgConverter.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language