Sign upLogin

eliashaeussler/typo3-warming

View on GitHub
Star
Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts

Summary

Maintainability
A
0 mins
Test Coverage

Function render has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

  protected render(): TemplateResult {
    // Add text if no URLs were crawled
    if (this.progress.getTotalNumberOfCrawledUrls() === 0) {
      return this.createEmptyCrawlingNotice();
    }
Severity: Major
Found in Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts - About 2 hrs to fix

    Function createModal has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

      public static createModal(
    progress: WarmupProgress,
    retryFunction: () => Promise<WarmupProgress>,
  ): void {
    // Ensure all other modals are closed
    Severity: Minor
    Found in Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts - About 1 hr to fix

      Function render has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Wontfix

        protected render(): TemplateResult {
    // Add text if no URLs were crawled
    if (this.progress.getTotalNumberOfCrawledUrls() === 0) {
      return this.createEmptyCrawlingNotice();
    }
      Severity: Minor
      Found in Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

              ${this.progress.getNumberOfFailedUrls() > 0 ? html`
          <warming-report-summary-card
            class="col-4"
            title="${TYPO3.lang[LanguageKeys.modalReportPanelFailed]}"
            body="${TYPO3.lang[LanguageKeys.modalReportPanelFailedSummary]}"
      Severity: Major
      Found in Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts and 1 other location - About 2 hrs to fix
      Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts on lines 72..82

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

              ${this.progress.getNumberOfSuccessfulUrls() > 0 ? html`
          <warming-report-summary-card
            class="col-4"
            title="${TYPO3.lang[LanguageKeys.modalReportPanelSuccessful]}"
            body="${TYPO3.lang[LanguageKeys.modalReportPanelSuccessfulSummary]}"
      Severity: Major
      Found in Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts and 1 other location - About 2 hrs to fix
      Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts on lines 60..70

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Wontfix

              ${this.progress.getNumberOfSuccessfulUrls() > 0 ? html`
          <warming-report-panel
            title="${TYPO3.lang[LanguageKeys.modalReportPanelSuccessful]}"
            state="success"
            urls="${JSON.stringify(this.progress.urls.successful)}"
      Severity: Major
      Found in Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts and 3 other locations - About 1 hr to fix
      Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts on lines 97..103
      Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts on lines 113..119
      Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts on lines 121..127

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Wontfix

              ${this.progress.getNumberOfExcludedUrls() > 0 ? html`
          <warming-report-panel
            title="${TYPO3.lang[LanguageKeys.modalReportPanelExcludedUrls]}"
            state="warning"
            urls="${JSON.stringify(this.progress.excluded.urls)}"
      Severity: Major
      Found in Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts and 3 other locations - About 1 hr to fix
      Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts on lines 97..103
      Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts on lines 105..111
      Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts on lines 113..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Wontfix

              ${this.progress.getNumberOfExcludedSitemaps() > 0 ? html`
          <warming-report-panel
            title="${TYPO3.lang[LanguageKeys.modalReportPanelExcludedSitemaps]}"
            state="warning"
            urls="${JSON.stringify(this.progress.excluded.sitemaps)}"
      Severity: Major
      Found in Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts and 3 other locations - About 1 hr to fix
      Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts on lines 97..103
      Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts on lines 105..111
      Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts on lines 121..127

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Wontfix

              ${this.progress.getNumberOfFailedUrls() > 0 ? html`
          <warming-report-panel
            title="${TYPO3.lang[LanguageKeys.modalReportPanelFailed]}"
            state="danger"
            urls="${JSON.stringify(this.progress.urls.failed)}"
      Severity: Major
      Found in Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts and 3 other locations - About 1 hr to fix
      Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts on lines 105..111
      Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts on lines 113..119
      Resources/Private/Frontend/src/scripts/backend/modal/report-modal.ts on lines 121..127

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status