Sign upLogin

eligible/knife-bastion

View on GitHub
Star
lib/chef/knife/bastion_start.rb

Summary

Maintainability
A
0 mins
Test Coverage

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

        if proxy_pid
Severity: Minor
Found in lib/chef/knife/bastion_start.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Prefer $CHILD_STATUS from the stdlib 'English' module (don't forget to require it) over $?.
Open

        if $?.exitstatus == 0
Severity: Minor
Found in lib/chef/knife/bastion_start.rb by rubocop

There are no issues that match your filters.

Category
Status