Sign upLogin

elisei/pagbank-payment-magento

View on GitHub
Star
Gateway/Command/PaymentCommand.php

Summary

Maintainability
A
1 hr
Test Coverage

Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

        CommandPoolInterface $commandPool,
        BuilderInterface $requestBuilder,
        TransferFactoryInterface $transferFactory,
        ClientInterface $client,
        LoggerInterface $logger,
Severity: Major
Found in Gateway/Command/PaymentCommand.php - About 1 hr to fix

    Function processErrors has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function processErrors(ResultInterface $result)
    {
        $messages = [];
        $errorsSource = array_merge($result->getErrorCodes(), $result->getFailsDescription());
        foreach ($errorsSource as $errorCodeOrMessage) {
    Severity: Minor
    Found in Gateway/Command/PaymentCommand.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Assigning ?\Magento\Payment\Gateway\Response\HandlerInterface to property but \PagBank\PaymentMagento\Gateway\Command\PaymentCommand->handler is \Magento\Payment\Gateway\Response\HandlerInterface
    Open

            $this->handler = $handler;
    Severity: Minor
    Found in Gateway/Command/PaymentCommand.php by phan

    Assigning ?\Magento\Payment\Gateway\Validator\ValidatorInterface to property but \PagBank\PaymentMagento\Gateway\Command\PaymentCommand->validator is \Magento\Payment\Gateway\Validator\ValidatorInterface
    Open

            $this->validator = $validator;
    Severity: Minor
    Found in Gateway/Command/PaymentCommand.php by phan

    Doc-block of $validator in __construct is phpdoc param type \Magento\Payment\Gateway\Validator\ValidatorInterface which is not a permitted replacement of the nullable param type ?\Magento\Payment\Gateway\Validator\ValidatorInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
    Open

         * @param ValidatorInterface               $validator
    Severity: Minor
    Found in Gateway/Command/PaymentCommand.php by phan

    Doc-block of $handler in __construct is phpdoc param type \Magento\Payment\Gateway\Response\HandlerInterface which is not a permitted replacement of the nullable param type ?\Magento\Payment\Gateway\Response\HandlerInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
    Open

         * @param HandlerInterface                 $handler
    Severity: Minor
    Found in Gateway/Command/PaymentCommand.php by phan

    There are no issues that match your filters.

    Category
    Status