Gateway/Command/PaymentCommand.php
Method __construct
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
CommandPoolInterface $commandPool,
BuilderInterface $requestBuilder,
TransferFactoryInterface $transferFactory,
ClientInterface $client,
LoggerInterface $logger,
Function processErrors
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
protected function processErrors(ResultInterface $result)
{
$messages = [];
$errorsSource = array_merge($result->getErrorCodes(), $result->getFailsDescription());
foreach ($errorsSource as $errorCodeOrMessage) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Assigning ?\Magento\Payment\Gateway\Response\HandlerInterface
to property but \PagBank\PaymentMagento\Gateway\Command\PaymentCommand->handler
is \Magento\Payment\Gateway\Response\HandlerInterface
Open
Open
$this->handler = $handler;
- Exclude checks
Assigning ?\Magento\Payment\Gateway\Validator\ValidatorInterface
to property but \PagBank\PaymentMagento\Gateway\Command\PaymentCommand->validator
is \Magento\Payment\Gateway\Validator\ValidatorInterface
Open
Open
$this->validator = $validator;
- Exclude checks
Doc-block of $handler
in __construct
is phpdoc param type \Magento\Payment\Gateway\Response\HandlerInterface
which is not a permitted replacement of the nullable param type ?\Magento\Payment\Gateway\Response\HandlerInterface
declared in the signature ('?T' should be documented as 'T|null' or '?T') Open
Open
* @param HandlerInterface $handler
- Exclude checks
Doc-block of $validator
in __construct
is phpdoc param type \Magento\Payment\Gateway\Validator\ValidatorInterface
which is not a permitted replacement of the nullable param type ?\Magento\Payment\Gateway\Validator\ValidatorInterface
declared in the signature ('?T' should be documented as 'T|null' or '?T') Open
Open
* @param ValidatorInterface $validator
- Exclude checks