Sign upLogin

elisei/pagbank-payment-magento

View on GitHub
Star
Gateway/Request/ItemsDataRequest.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method getPurchaseItems has 55 lines of code (exceeds 40 allowed). Consider refactoring.
Open

    public function getPurchaseItems(
        $order
    ) {
        $result = [];
        $items = $order->getItems();
Severity: Major
Found in Gateway/Request/ItemsDataRequest.php - About 1 hr to fix

    Function getPurchaseItems has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getPurchaseItems(
        $order
    ) {
        $result = [];
        $items = $order->getItems();
    Severity: Minor
    Found in Gateway/Request/ItemsDataRequest.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Possibly zero references to use statement for classlike/namespace PaymentDataObject (\Magento\Payment\Gateway\Data\PaymentDataObject)
    Open

    use Magento\Payment\Gateway\Data\PaymentDataObject;
    Severity: Minor
    Found in Gateway/Request/ItemsDataRequest.php by phan

    There are no issues that match your filters.

    Category
    Status