Sign upLogin

elisei/pagbank-payment-magento

View on GitHub
Star
Gateway/Response/FetchPaymentHandler.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function handle has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function handle(array $handlingSubject, array $response)
    {
        if (!isset($handlingSubject['payment'])
            || !$handlingSubject['payment'] instanceof PaymentDataObjectInterface
        ) {
Severity: Minor
Found in Gateway/Response/FetchPaymentHandler.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function findForPaymentStatus has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function findForPaymentStatus($response, $charges)
    {
        $isPix = isset($response[self::RESPONSE_QR_CODES]);
        $isTempCancel = false;
Severity: Minor
Found in Gateway/Response/FetchPaymentHandler.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Possibly zero references to use statement for classlike/namespace LocalizedException (\Magento\Framework\Exception\LocalizedException)
Open

use Magento\Framework\Exception\LocalizedException;
Severity: Minor
Found in Gateway/Response/FetchPaymentHandler.php by phan

Assigning null to property but \PagBank\PaymentMagento\Gateway\Response\FetchPaymentHandler->finalStatus is string
Open

        $this->finalStatus = null;
Severity: Minor
Found in Gateway/Response/FetchPaymentHandler.php by phan

There are no issues that match your filters.

Category
Status