elisei/pagbank-payment-magento

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

        Json $json,
        ObjectManagerInterface $objectManager,
        OrderPaymentExtensionInterfaceFactory $payExtensionFactory,
        ConfigCc $configCc,
        PaymentTokenFactoryInterface $paymentTokenFactory = null

Doc-block of $paymentTokenFactory in __construct is phpdoc param type \Magento\Vault\Api\Data\PaymentTokenFactoryInterface which is not a permitted replacement of the nullable param type ?\Magento\Vault\Api\Data\PaymentTokenFactoryInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')

Open

     * @param PaymentTokenFactoryInterface          $paymentTokenFactory

• Exclude checks
  • Disable engine
  • Disable check

Assigning \Magento\Vault\Api\Data\PaymentTokenFactoryInterface to property but \PagBank\PaymentMagento\Gateway\Response\VaultDetailsHandler->paymentTokenFactory is \Magento\Vault\Api\Data\PaymentTokenInterfaceFactory

Open

        $this->paymentTokenFactory = $paymentTokenFactory;

• Exclude checks
  • Disable engine
  • Disable check

Doc-block of getCreditCardType has declared return type string which is not a permitted replacement of the nullable return type ?string declared in the signature ('?T' should be documented as 'T|null' or '?T')

Open

     * @return string

• Exclude checks
  • Disable engine
  • Disable check

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    public function getCreditCardType(string $type): ?string
    {
        $type = strtoupper($type);
        $mapper = $this->configCc->getCcTypesMapper();

• Read up
  Read up