Sign upLogin

elisei/pagbank-payment-magento

View on GitHub
Star
Model/Api/ConsultPSInstallments.php

Summary

Maintainability
A
1 hr
Test Coverage

Method getPagBankInstallments has 44 lines of code (exceeds 40 allowed). Consider refactoring.
Open

    public function getPagBankInstallments($storeId, $creditCardBin, $amount, $cardTypeTransaction = 'CREDIT_CARD')
    {
        /** @var LaminasClient $client */
        $client = $this->httpClientFactory->create();
        $url = $this->configBase->getApiUrl($storeId);
Severity: Minor
Found in Model/Api/ConsultPSInstallments.php - About 1 hr to fix

    Function getAvailableInstallments has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getAvailableInstallments($list, $storeId)
    {
        $minInstallment = $this->configCc->getMinValuelInstallment($storeId) * 100;

        foreach ($list as $key => $allInstallments) {
    Severity: Minor
    Found in Model/Api/ConsultPSInstallments.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Possibly zero references to use statement for classlike/namespace LaminasClient (\Magento\Framework\HTTP\LaminasClient)
    Open

    use Magento\Framework\HTTP\LaminasClient;
    Severity: Minor
    Found in Model/Api/ConsultPSInstallments.php by phan

    There are no issues that match your filters.

    Category
    Status