Sign upLogin

elitmus/omniauth-elitmus

View on GitHub
Star

Showing 126 of 126 total issues

Use 2 (not 1) spaces for indentation.
Open

                options[:callback_url] || super
Severity: Minor
Found in lib/omniauth/strategies/elitmus.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 1) spaces for indentation.
Open

                hash.delete_if do |_, value|
Severity: Minor
Found in lib/omniauth/strategies/elitmus.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Missing space after #.
Open

            #OATUH2_PROVIDER_URL = "https://www.elitmus.com"
Severity: Minor
Found in lib/omniauth/strategies/elitmus.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Tab detected.
Open

            option :client_options, {
Severity: Minor
Found in lib/omniauth/strategies/elitmus.rb by rubocop

Line is too long. [87/80]
Open

  spec.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
Severity: Minor
Found in omniauth-elitmus.gemspec by rubocop

Prefer $LOAD_PATH over $:.
Open

$:.push File.expand_path('../lib', __FILE__)
Severity: Minor
Found in omniauth-elitmus.gemspec by rubocop
Severity
Category
Status
Source
Language