Sign upLogin

elliotchance/gedcom

View on GitHub
Star
birth_node.go

Summary

Maintainability
A
2 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package gedcom

// BirthNode is the event of entering into life.
type BirthNode struct {
    *SimpleNode
Severity: Major
Found in birth_node.go and 1 other location - About 2 hrs to fix
death_node.go on lines 1..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 213.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

comment on exported method BirthNode.Equals should be of the form "Equals ..."
Open

// Equal will always return true if both nodes are not nil.
Severity: Minor
Found in birth_node.go by golint

There are no issues that match your filters.

Category
Status