Sign upLogin

elliotchance/gedcom

View on GitHub
Star
html/diff_page.go

Summary

Maintainability
A
2 hrs
Test Coverage

Method DiffPage.WriteHTMLTo has 55 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *DiffPage) WriteHTMLTo(w io.Writer) (int64, error) {
    if c.progress != nil {
        c.progress <- gedcom.Progress{
            Total: int64(len(c.comparisons)),
        }
Severity: Minor
Found in html/diff_page.go - About 1 hr to fix

    Function NewDiffPage has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func NewDiffPage(comparisons gedcom.IndividualComparisons, filterFlags *gedcom.FilterFlags, googleAnalyticsID string, show, sort string, progress chan gedcom.Progress, compareOptions *gedcom.IndividualNodesCompareOptions, visibility LivingVisibility) *DiffPage {
    Severity: Major
    Found in html/diff_page.go - About 50 mins to fix

      exported function NewDiffPage should have comment or be unexported
      Open

      func NewDiffPage(comparisons gedcom.IndividualComparisons, filterFlags *gedcom.FilterFlags, googleAnalyticsID string, show, sort string, progress chan gedcom.Progress, compareOptions *gedcom.IndividualNodesCompareOptions, visibility LivingVisibility) *DiffPage {
      Severity: Minor
      Found in html/diff_page.go by golint

      exported type DiffPage should have comment or be unexported
      Open

      type DiffPage struct {
      Severity: Minor
      Found in html/diff_page.go by golint

      exported method DiffPage.WriteHTMLTo should have comment or be unexported
      Open

      func (c *DiffPage) WriteHTMLTo(w io.Writer) (int64, error) {
      Severity: Minor
      Found in html/diff_page.go by golint

      There are no issues that match your filters.

      Category
      Status