Sign upLogin

elliotchance/gedcom

View on GitHub
Star
html/individual_events.go

Summary

Maintainability
A
1 hr
Test Coverage

Method IndividualEvents.WriteHTMLTo has 57 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *IndividualEvents) WriteHTMLTo(w io.Writer) (int64, error) {
    var events []core.Component

    for _, event := range c.individual.AllEvents() {
        date, place := gedcom.DateAndPlace(event)
Severity: Minor
Found in html/individual_events.go - About 1 hr to fix

    Method IndividualEvents.WriteHTMLTo has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
    Open

    func (c *IndividualEvents) WriteHTMLTo(w io.Writer) (int64, error) {
    var events []core.Component

    for _, event := range c.individual.AllEvents() {
        date, place := gedcom.DateAndPlace(event)
    Severity: Minor
    Found in html/individual_events.go - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    exported method IndividualEvents.WriteHTMLTo should have comment or be unexported
    Open

    func (c *IndividualEvents) WriteHTMLTo(w io.Writer) (int64, error) {
    Severity: Minor
    Found in html/individual_events.go by golint

    exported function NewIndividualEvents should have comment or be unexported
    Open

    func NewIndividualEvents(document *gedcom.Document, individual *gedcom.IndividualNode, visibility LivingVisibility, placesMap map[string]*place) *IndividualEvents {
    Severity: Minor
    Found in html/individual_events.go by golint

    There are no issues that match your filters.

    Category
    Status