Sign upLogin

elliotchance/gedcom

View on GitHub
Star
html/individual_list_page.go

Summary

Maintainability
A
2 hrs
Test Coverage

Method IndividualListPage.WriteHTMLTo has 65 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *IndividualListPage) WriteHTMLTo(w io.Writer) (int64, error) {
    table := []core.Component{
        core.NewTableHead("Name", "Birth", "Death"),
    }
Severity: Minor
Found in html/individual_list_page.go - About 1 hr to fix

    Function NewIndividualListPage has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func NewIndividualListPage(document *gedcom.Document, selectedLetter rune, googleAnalyticsID string, options *PublishShowOptions, indexLetters []rune, placesMap map[string]*place) *IndividualListPage {
    Severity: Minor
    Found in html/individual_list_page.go - About 45 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      func NewIndividualListPage(document *gedcom.Document, selectedLetter rune, googleAnalyticsID string, options *PublishShowOptions, indexLetters []rune, placesMap map[string]*place) *IndividualListPage {
    return &IndividualListPage{
        document:          document,
        selectedLetter:    selectedLetter,
        googleAnalyticsID: googleAnalyticsID,
      Severity: Minor
      Found in html/individual_list_page.go and 2 other locations - About 35 mins to fix
      html/place_page.go on lines 19..28
      html/publish_header.go on lines 31..40

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 103.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      exported method IndividualListPage.WriteHTMLTo should have comment or be unexported
      Open

      func (c *IndividualListPage) WriteHTMLTo(w io.Writer) (int64, error) {
      Severity: Minor
      Found in html/individual_list_page.go by golint

      should replace livingCount += 1 with livingCount++
      Open

                      livingCount += 1
      Severity: Minor
      Found in html/individual_list_page.go by golint

      exported function NewIndividualListPage should have comment or be unexported
      Open

      func NewIndividualListPage(document *gedcom.Document, selectedLetter rune, googleAnalyticsID string, options *PublishShowOptions, indexLetters []rune, placesMap map[string]*place) *IndividualListPage {
      Severity: Minor
      Found in html/individual_list_page.go by golint

      There are no issues that match your filters.

      Category
      Status