Sign upLogin

elliotchance/gedcom

View on GitHub
Star
individual_nodes.go

Summary

Maintainability
A
1 hr
Test Coverage

Method IndividualNodesCompareOptions.calculateWinners has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
Open

func (o *IndividualNodesCompareOptions) calculateWinners(a, b IndividualNodes, similarityResults chan *IndividualComparison, options SimilarityOptions) chan *IndividualComparison {
    // See description in createJobs().
    winners := make(chan *IndividualComparison, 1000)

    go func() {
Severity: Minor
Found in individual_nodes.go - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method IndividualNodesCompareOptions.collectResults has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func (o *IndividualNodesCompareOptions) collectResults(results chan *IndividualComparison, totals chan int64) chan *IndividualComparison {
    // See description in createJobs().
    similarities := make(chan *IndividualComparison, 1000)

    go func() {
Severity: Minor
Found in individual_nodes.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Your code does not pass gofmt in 5 places. Go fmt your code!
Open

package gedcom
Severity: Minor
Found in individual_nodes.go by gofmt

exported method IndividualNodes.ByPointer should have comment or be unexported
Open

func (nodes IndividualNodes) ByPointer(pointer string) *IndividualNode {
Severity: Minor
Found in individual_nodes.go by golint

There are no issues that match your filters.

Category
Status