Sign upLogin

elliotchance/gedcom

View on GitHub
Star
q/binary_expr.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method BinaryExpr.Evaluate has 6 return statements (exceeds 4 allowed).
Open

func (e *BinaryExpr) Evaluate(engine *Engine, input interface{}, args []*Statement) (interface{}, error) {
    in := reflect.ValueOf(input)

    // If it is a slice we need to Evaluate each one.
    if in.Kind() == reflect.Slice {
Severity: Major
Found in q/binary_expr.go - About 40 mins to fix

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    func lessThan(left, right interface{}) (bool, error) {
    sLeft, sRight := binaryStrings(left, right)

    if floatLeft, floatRight, ok := binaryFloats(sLeft, sRight); ok {
        return floatLeft < floatRight, nil
    Severity: Major
    Found in q/binary_expr.go and 4 other locations - About 40 mins to fix
    q/binary_expr.go on lines 110..125
    q/binary_expr.go on lines 136..148
    q/binary_expr.go on lines 150..162
    q/binary_expr.go on lines 178..190

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    func greaterThan(left, right interface{}) (bool, error) {
    sLeft, sRight := binaryStrings(left, right)

    if floatLeft, floatRight, ok := binaryFloats(sLeft, sRight); ok {
        return floatLeft > floatRight, nil
    Severity: Major
    Found in q/binary_expr.go and 4 other locations - About 40 mins to fix
    q/binary_expr.go on lines 110..125
    q/binary_expr.go on lines 150..162
    q/binary_expr.go on lines 164..176
    q/binary_expr.go on lines 178..190

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    func greaterThanEqual(left, right interface{}) (bool, error) {
    sLeft, sRight := binaryStrings(left, right)

    if floatLeft, floatRight, ok := binaryFloats(sLeft, sRight); ok {
        return floatLeft >= floatRight, nil
    Severity: Major
    Found in q/binary_expr.go and 4 other locations - About 40 mins to fix
    q/binary_expr.go on lines 110..125
    q/binary_expr.go on lines 136..148
    q/binary_expr.go on lines 164..176
    q/binary_expr.go on lines 178..190

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    func lessThanEqual(left, right interface{}) (bool, error) {
    sLeft, sRight := binaryStrings(left, right)

    if floatLeft, floatRight, ok := binaryFloats(sLeft, sRight); ok {
        return floatLeft <= floatRight, nil
    Severity: Major
    Found in q/binary_expr.go and 4 other locations - About 40 mins to fix
    q/binary_expr.go on lines 110..125
    q/binary_expr.go on lines 136..148
    q/binary_expr.go on lines 150..162
    q/binary_expr.go on lines 164..176

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    func equal(left, right interface{}) (bool, error) {
    sLeft, sRight := binaryStrings(left, right)

    // Compare as numbers.
    if floatLeft, floatRight, ok := binaryFloats(sLeft, sRight); ok {
    Severity: Major
    Found in q/binary_expr.go and 4 other locations - About 40 mins to fix
    q/binary_expr.go on lines 136..148
    q/binary_expr.go on lines 150..162
    q/binary_expr.go on lines 164..176
    q/binary_expr.go on lines 178..190

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    exported method BinaryExpr.Evaluate should have comment or be unexported
    Open

    func (e *BinaryExpr) Evaluate(engine *Engine, input interface{}, args []*Statement) (interface{}, error) {
    Severity: Minor
    Found in q/binary_expr.go by golint

    There are no issues that match your filters.

    Category
    Status