Sign upLogin

elliotchance/gedcom

View on GitHub
Star
simple_node.go

Summary

Maintainability
A
35 mins
Test Coverage

Method SimpleNode.Equals has 5 return statements (exceeds 4 allowed).
Open

func (node *SimpleNode) Equals(node2 Node) bool {
    if node == nil {
        return false
    }
Severity: Major
Found in simple_node.go - About 35 mins to fix

    Your code does not pass gofmt in 1 place. Go fmt your code!
    Open

    package gedcom
    Severity: Minor
    Found in simple_node.go by gofmt

    comment on exported method SimpleNode.Tag should be of the form "Tag ..."
    Open

    // If the node is nil the result will be an empty tag.
    Severity: Minor
    Found in simple_node.go by golint

    comment on exported method SimpleNode.Value should be of the form "Value ..."
    Open

    // If the node is nil the result will be an empty string.
    Severity: Minor
    Found in simple_node.go by golint

    comment on exported method SimpleNode.Pointer should be of the form "Pointer ..."
    Open

    // If the node is nil the result will be an empty string.
    Severity: Minor
    Found in simple_node.go by golint

    exported method SimpleNode.AddNode should have comment or be unexported
    Open

    func (node *SimpleNode) AddNode(n Node) {
    Severity: Minor
    Found in simple_node.go by golint

    exported method SimpleNode.DeleteNode should have comment or be unexported
    Open

    func (node *SimpleNode) DeleteNode(n Node) (didDelete bool) {
    Severity: Minor
    Found in simple_node.go by golint

    exported method SimpleNode.MarshalJSON should have comment or be unexported
    Open

    func (node *SimpleNode) MarshalJSON() ([]byte, error) {
    Severity: Minor
    Found in simple_node.go by golint

    exported method SimpleNode.ObjectMap should have comment or be unexported
    Open

    func (node *SimpleNode) ObjectMap() map[string]interface{} {
    Severity: Minor
    Found in simple_node.go by golint

    comment on exported method SimpleNode.Nodes should be of the form "Nodes ..."
    Open

    // If the node is nil the result will also be nil.
    Severity: Minor
    Found in simple_node.go by golint

    exported method SimpleNode.RawSimpleNode should have comment or be unexported
    Open

    func (node *SimpleNode) RawSimpleNode() *SimpleNode {
    Severity: Minor
    Found in simple_node.go by golint

    There are no issues that match your filters.

    Category
    Status