elliotwutingfeng/Inversion-DNSBL-Generator

View on GitHub
modules/safebrowsing.py

Summary

Maintainability
B
4 hrs
Test Coverage

File safebrowsing.py has 335 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""
Safe Browsing API helper class
"""

import asyncio
Severity: Minor
Found in modules/safebrowsing.py - About 4 hrs to fix

    Function get_malicious_url_hash_prefixes has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_malicious_url_hash_prefixes(self, threat_list_updates: dict) -> set[str]:
            """Download latest b64 encoded malicious URL hash prefixes from Safe Browsing API.
    
            The uncompressed threat entries in hash format of a particular prefix length.
            Hashes can be anywhere from 4 to 32 bytes in size. A large majority are 4 bytes,
    Severity: Minor
    Found in modules/safebrowsing.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status