Sign upLogin

emilepharand/Babilonia

View on GitHub
Star
server/model/inputValidator.ts

Summary

Maintainability
B
4 hrs
Test Coverage

Function validateContextParentheses has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

export function validateContextParentheses(ee: ExpressionForAdding[]) {
    for (const e of ee) {
        const contexts = e.text.match(/\([^)(]*\)/g) ?? [];
        // No context is empty
        if (contexts.some(x => x.substring(1, x.length - 1).trim().length === 0)) {
Severity: Minor
Found in server/model/inputValidator.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return false;
Severity: Major
Found in server/model/inputValidator.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return validateContextParentheses(ideaForAdding.ee);
    Severity: Major
    Found in server/model/inputValidator.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return false;
      Severity: Major
      Found in server/model/inputValidator.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return false;
        Severity: Major
        Found in server/model/inputValidator.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return InputValidator.isValidOrdering(ll.map(l => l.ordering));
          Severity: Major
          Found in server/model/inputValidator.ts - About 30 mins to fix

            Function validateLanguagesForEditing has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public async validateLanguagesForEditing(toValidate: unknown): Promise<boolean> {
        // Object is an array
        if (!Array.isArray(toValidate)) {
            return false;
        }
            Severity: Minor
            Found in server/model/inputValidator.ts - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status