Sign upLogin

emiloberg/node-red-contrib-file-function

View on GitHub
Star

Showing 7 of 7 total issues

Function exports has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function(RED) {
    "use strict";
    var util = require("util");
    var vm = require("vm");
    var fs = require("fs");
Severity: Minor
Found in file-function/file-function.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(RED) {
    "use strict";
    var util = require("util");
    var vm = require("vm");
    var fs = require("fs");
Severity: Major
Found in file-function/file-function.js - About 3 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                        if (err.code === 'ENOENT') {
                        node.warn('Could not find file "' + err.path + '". Hint: File path is relative to "' + process.env.PWD + '"');
                    } else {
                        node.warn(err);
                    }
    Severity: Major
    Found in file-function/file-function.js and 1 other location - About 1 hr to fix
    file-function/file-function.js on lines 61..65

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 69.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                            if (err.code === 'ENOENT') {
                            node.warn('Could not find file "' + err.path + '". Hint: File path is relative to "' + process.env.PWD + '"');
                        } else {
                            node.warn(err);
                        }
    Severity: Major
    Found in file-function/file-function.js and 1 other location - About 1 hr to fix
    file-function/file-function.js on lines 38..42

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 69.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function FunctionNode has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function FunctionNode(n) {
        RED.nodes.createNode(this, n);

        this.filename = n.filename || "";
        this.loadedScript = '';
    Severity: Minor
    Found in file-function/file-function.js - About 1 hr to fix

      Function runScript has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function runScript(node, msg, script) {
        var functionText = "var results = null; results = (function(msg){"+script+"\n})(msg);";

        var sandbox = {
            console:console,
      Severity: Minor
      Found in file-function/file-function.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                                    for (var n=0; n < results[m].length; n++) {
                                results[m][n].topic = msg.topic;
                            }
        Severity: Major
        Found in file-function/file-function.js - About 45 mins to fix
          Severity
          Category
          Status
          Source
          Language