Sign upLogin

emilsoman/cloudster

View on GitHub
Star

Showing 9 of 9 total issues

Method template has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def template
        return "Resources" => {
          @instance_name => {
            "Metadata" => {
              "AWS::CloudFormation::Init" => {
Severity: Major
Found in lib/cloudster/chef_client.rb - About 2 hrs to fix

    Method template has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def template
        template = { "Resources" => {
            @name => {
                "Type" => "AWS::CloudFront::Distribution",
                "Properties" => {
    Severity: Minor
    Found in lib/cloudster/cloud_front.rb - About 1 hr to fix

      Method template has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def self.template(options = {})
      require_options(options, [:name, :instance_names])
      properties = {"AvailabilityZones" => { "Fn::GetAZs" => "" },
        "Listeners" => get_listeners_for_template(options[:listeners]),
        "HealthCheck" => {
      Severity: Minor
      Found in lib/cloudster/elb.rb - About 1 hr to fix

        Method template has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def self.template(options = {})
      require_options(options, [:name, :storage_size])
      options[:username] ||= 'root'
      options[:password] ||= 'root'
      options[:engine] ||= 'MySQL'
        Severity: Minor
        Found in lib/cloudster/rds.rb - About 1 hr to fix

          Method template has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def self.template(options = {})
      require_options(options, [:name, :key_name, :image_id])
      properties = {}
      properties.merge!({"KeyName" => options[:key_name], "ImageId" => options[:image_id]})
      properties.merge!({"InstanceType" => options[:instance_type]}) unless options[:instance_type].nil?
          Severity: Minor
          Found in lib/cloudster/ec2.rb - About 1 hr to fix

            Method get_database_endpoints has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def get_database_endpoints(options = {})
      rds_physical_ids = get_resource_ids(resources(options), "AWS::RDS::DBInstance").values
      return [] if rds_physical_ids.empty?
      rds = Fog::AWS::RDS.new(:aws_access_key_id => @access_key_id, :aws_secret_access_key => @secret_access_key, :region => @region)
      endpoints = []
            Severity: Minor
            Found in lib/cloudster/cloud.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method template has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def template(options = {})
      require_options(options, [:resources])
      resources = options[:resources]
      description = options[:description] || 'This stack is created by Cloudster'
      resource_template = {}
            Severity: Minor
            Found in lib/cloudster/cloud.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                def provision(options = {})
      require_options(options, [:resources, :stack_name])
      return @cloud_formation.create_stack(options[:stack_name], 'TemplateBody' => template(:resources => options[:resources], 
                                                                                            :description => options[:description]))
            Severity: Minor
            Found in lib/cloudster/cloud.rb and 1 other location - About 20 mins to fix
            lib/cloudster/cloud.rb on lines 135..138

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 27.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                def update(options = {})
      require_options(options, [:resources, :stack_name])
      return @cloud_formation.update_stack(options[:stack_name], 'TemplateBody' => template(:resources => options[:resources], 
                                                                                            :description => options[:description]))
            Severity: Minor
            Found in lib/cloudster/cloud.rb and 1 other location - About 20 mins to fix
            lib/cloudster/cloud.rb on lines 103..106

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 27.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language