emmercm/igir

View on GitHub
src/modules/candidates/candidateArchiveFileHasher.ts

Summary

Maintainability
D
1 day
Test Coverage

Function hashArchiveFiles has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private async hashArchiveFiles(
    dat: DAT,
    parentsToCandidates: Map<Parent, ReleaseCandidate[]>,
  ): Promise<Map<Parent, ReleaseCandidate[]>> {
    return new Map(
Severity: Major
Found in src/modules/candidates/candidateArchiveFileHasher.ts - About 2 hrs to fix

    Function hashedReleaseCandidates has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                  releaseCandidates.map(async (releaseCandidate) => {
                    const hashedRomsWithFiles = await Promise.all(
                      releaseCandidate.getRomsWithFiles().map(async (romWithFiles) => {
                        const inputFile = romWithFiles.getInputFile();
                        if (!(inputFile instanceof ArchiveFile)) {
    Severity: Minor
    Found in src/modules/candidates/candidateArchiveFileHasher.ts - About 1 hr to fix

      Function hashedRomsWithFiles has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                        releaseCandidate.getRomsWithFiles().map(async (romWithFiles) => {
                          const inputFile = romWithFiles.getInputFile();
                          if (!(inputFile instanceof ArchiveFile)) {
                            return romWithFiles;
                          }
      Severity: Minor
      Found in src/modules/candidates/candidateArchiveFileHasher.ts - About 1 hr to fix

        Function hash has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          async hash(
            dat: DAT,
            parentsToCandidates: Map<Parent, ReleaseCandidate[]>,
          ): Promise<Map<Parent, ReleaseCandidate[]>> {
            if (parentsToCandidates.size === 0) {
        Severity: Minor
        Found in src/modules/candidates/candidateArchiveFileHasher.ts - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            constructor(options: Options, progressBar: ProgressBar, fileFactory: FileFactory) {
              super(progressBar, CandidateArchiveFileHasher.name);
              this.options = options;
              this.fileFactory = fileFactory;
          
          
          Severity: Major
          Found in src/modules/candidates/candidateArchiveFileHasher.ts and 1 other location - About 4 hrs to fix
          src/modules/candidates/candidateExtensionCorrector.ts on lines 31..40

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 120.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              this.progressBar.logTrace(
                `${dat.getNameShort()}: generating ${archiveFileCount.toLocaleString()} hashed ArchiveFile candidate${archiveFileCount !== 1 ? 's' : ''}`,
              );
          Severity: Major
          Found in src/modules/candidates/candidateArchiveFileHasher.ts and 1 other location - About 1 hr to fix
          src/modules/candidates/candidateExtensionCorrector.ts on lines 65..67

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                                  this.progressBar.logTrace(
                                    `${dat.getNameShort()}: ${parent.getName()}: calculating checksums for: ${inputFile.toString()}`,
                                  );
          Severity: Major
          Found in src/modules/candidates/candidateArchiveFileHasher.ts and 2 other locations - About 55 mins to fix
          src/modules/candidates/candidatePatchGenerator.ts on lines 187..189
          src/modules/candidates/candidatePreferer.ts on lines 90..92

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 8 locations. Consider refactoring.
          Open

              if (parentsToCandidates.size === 0) {
                this.progressBar.logTrace(`${dat.getNameShort()}: no parents to hash ArchiveFiles for`);
                return parentsToCandidates;
              }
          Severity: Major
          Found in src/modules/candidates/candidateArchiveFileHasher.ts and 7 other locations - About 40 mins to fix
          src/modules/candidates/candidateCombiner.ts on lines 36..39
          src/modules/candidates/candidateExtensionCorrector.ts on lines 49..52
          src/modules/candidates/candidatePatchGenerator.ts on lines 33..36
          src/modules/candidates/candidatePostProcessor.ts on lines 29..32
          src/modules/candidates/candidatePreferer.ts on lines 30..33
          src/modules/dats/datScanner.ts on lines 459..462
          src/modules/fixdatCreator.ts on lines 56..61

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (archiveFileCount === 0) {
                this.progressBar.logTrace(`${dat.getNameShort()}: no ArchiveFiles to hash`);
                return parentsToCandidates;
              }
          Severity: Minor
          Found in src/modules/candidates/candidateArchiveFileHasher.ts and 1 other location - About 30 mins to fix
          src/modules/candidates/candidateExtensionCorrector.ts on lines 58..63

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status